Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79742 --- Could you please create a diff with master branch please? - Jie Yu

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/ --- (Updated April 10, 2015, 7:47 p.m.) Review request for mesos, Chi Zhang, Ian Do

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79745 --- Bad patch! Reviews applied: [33040] Failed command: ./support/appl

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79743 --- Seems that it's still not rebased. - Jie Yu On April 10, 2015, 7:

Re: Review Request 27113: Libprocess benchmark cleanup

2015-04-10 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27113/ --- (Updated April 10, 2015, 8:59 p.m.) Review request for Cody Maloney, Joerg Scha

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Vinod Kone
> On April 10, 2015, 1:31 a.m., Cody Maloney wrote: > > For the approach I'm worried we're going to spend a lot of ASF CI time > > re-installing all the base dependencies + copying files in / out. Docker > > _can_ cache those steps and should for the most part, but still more work > > then not

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Vinod Kone
> On April 10, 2015, 1:09 a.m., Ben Mahler wrote: > > support/jenkins_build.sh, line 24 > > > > > > This only works for CentOS 7+ since otherwise we need devtoolset-2, did > > you want add a note? added a note. > On

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/ --- (Updated April 10, 2015, 9:31 p.m.) Review request for mesos, Ben Mahler and Co

Re: Review Request 32984: Added an example framework for testing persistent volumes.

2015-04-10 Thread Jie Yu
> On April 10, 2015, 6:40 p.m., Vinod Kone wrote: > > LGTM. Are you planning to add similar ones for java and python, because > > that's what framework writers would be most intersted in. A TODO for now is > > fine. Alternatively, you can convert the current example frameworks (cpp, > > java a

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/#review79759 --- Patch looks great! Reviews applied: [33045] All tests passed. - M

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/#review79772 --- LGTM. Maybe we should add a 'docker' check for mesos tests like the

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/ --- (Updated April 10, 2015, 11:17 p.m.) Review request for mesos, Chi Zhang, Ian D

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79776 --- configure.ac

Re: Review Request 33040: Expose qdisc statistics from libnl

2015-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33040/#review79783 --- Patch looks great! Reviews applied: [33040] All tests passed. - M

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/ --- (Updated April 11, 2015, 12:20 a.m.) Review request for mesos, Ben Mahler and C

Re: Review Request 33045: Added Jenkins build script to build Mesos inside Docker container.

2015-04-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33045/#review79789 --- Patch looks great! Reviews applied: [33045] All tests passed. - M