Re: [jira] [Commented] (MESOS-2368) Provide a backchannel for information to the framework

2015-04-11 Thread Timothy Chen
In the docker executor it can be done by the executor (once we have the docker executor, which makes this also easier). That's what I'm trying to figure out as well, should I just reuse data or introducing a brand new field for this as it can have a specific meaning that it is container specific i

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2879

2015-04-11 Thread Apache Jenkins Server
See

Re: [jira] [Updated] (MESOS-2558) Mark RunTaskMessage.framework_id as optional

2015-04-11 Thread Vinod Kone
Has this gone through niklas' compatibility test script? @vinodkone > On Apr 11, 2015, at 2:45 AM, Adam B (JIRA) wrote: > > > [ > https://issues.apache.org/jira/browse/MESOS-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Adam B updated MESOS-2558: > -

Re: [jira] [Commented] (MESOS-2368) Provide a backchannel for information to the framework

2015-04-11 Thread Vinod Kone
Who sends the information? If it's the executor can it just not use 'data' field in status? @vinodkone > On Apr 11, 2015, at 2:48 PM, Timothy Chen (JIRA) wrote: > > >[ > https://issues.apache.org/jira/browse/MESOS-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel

Re: Review Request 31028: Added slave run task hook tests.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/#review79804 --- src/examples/test_hook_module.cpp

Re: Review Request 32948: Refactored VerifyMasterLaunchTaskHook to _not_ use command executor.

2015-04-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32948/ --- (Updated April 11, 2015, 3:37 a.m.) Review request for mesos, Adam B and Kapil

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2878

2015-04-11 Thread Apache Jenkins Server
aster.cpp:1498] Authorizing framework principal 'test-principal' to receive offers for role '*' I0411 10:32:00.125080 9875 log.cpp:684] Attempting to append 316 bytes to the log I0411 10:32:00.125138 9880 master.cpp:1704] Registering framework 20150411-103159-3125920579-4

Re: Review Request 31016: Added slave run task decorator.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review79803 --- Looks good. Just a question about when we should actually do the dec

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review79802 --- Ship it! Ship It! - Adam B On April 7, 2015, 5:57 p.m., Niklas N

Re: Review Request 31017: Fixed comment for remove executor hook.

2015-04-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31017/ --- (Updated April 11, 2015, 3:03 a.m.) Review request for mesos and Kapil Arya.

Re: Review Request 31016: Added slave run task decorator.

2015-04-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/ --- (Updated April 11, 2015, 3:03 a.m.) Review request for mesos, Ben Mahler and Ka

Re: Review Request 31028: Added slave run task hook tests.

2015-04-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31028/ --- (Updated April 11, 2015, 3:03 a.m.) Review request for mesos, Ben Mahler and Ka

Re: Review Request 30961: Enabled label decorator to override.

2015-04-11 Thread Adam B
> On April 7, 2015, 1:41 a.m., Adam B wrote: > > src/hook/manager.cpp, line 104 > > > > > > Would it make sense to make taskInfo a pass-by-value param, forcing the > > copy at the call? > > Niklas Nielsen wrote: >

Re: Review Request 32586: Removed FrameworkID argument from Slave::_runTask.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32586/#review79800 --- Ship it! Ship It! - Adam B On April 7, 2015, 9:59 a.m., Kapil Ar

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79799 --- Ship it! Needs a quick rebase before committing. - Adam B On Apr

Re: Review Request 32583: Marked RunTaskMessage::framework_id as optional.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32583/#review79798 --- Ship it! Did you ever (manually?) "Test for upgrade path"? - Adam