[GitHub] mesos pull request #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread ktf
GitHub user ktf opened a pull request: https://github.com/apache/mesos/pull/141 Fix FrameworkInfo::user documentation Add a note about the user being required in case the HTTP Scheduler API is used. You can merge this pull request into a Git repository by running: $ git pul

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread haosdent
Github user haosdent commented on the issue: https://github.com/apache/mesos/pull/141 Please update `include/mesos/mesos.proto` as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread ktf
Github user ktf commented on the issue: https://github.com/apache/mesos/pull/141 Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread haosdent
Github user haosdent commented on the issue: https://github.com/apache/mesos/pull/141 LGTM. :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

Re: [VOTE] Release Apache Mesos 1.0.0 (rc2)

2016-07-15 Thread Alex Rukletsov
-1 (binding): MESOS-5848 . The fix is on the way. On Wed, Jul 13, 2016 at 1:19 AM, Zhitao Li wrote: > +1 (nonbinding) > > Tested by 1)running all tests on Mac OS, 2) perform upgrade and downgrade > on a small test cluster for both master and slav

Re: [VOTE] Release Apache Mesos 1.0.0 (rc2)

2016-07-15 Thread Alex Rukletsov
Haosdent investigated the issue, and it seems that health checks do work for docker executor. Hence I retract my negative vote. On Fri, Jul 15, 2016 at 12:57 PM, Alex Rukletsov wrote: > -1 (binding): MESOS-5848 > . The fix is on the way. > > On W

Re: [VOTE] Release Apache Mesos 1.0.0 (rc2)

2016-07-15 Thread haosdent
+1 Tested on CentOS 7. - sudo make check - upgrade from 0.28.2 to 1.0.0-rc2 On Fri, Jul 15, 2016 at 7:47 PM, Alex Rukletsov wrote: > Haosdent investigated the issue, and it seems that health checks do work > for docker executor. Hence I retract my negative vote. > > On Fri, Jul 15, 2016 at 12:

[GitHub] mesos pull request #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread zhitaoli
Github user zhitaoli commented on a diff in the pull request: https://github.com/apache/mesos/pull/141#discussion_r71003361 --- Diff: include/mesos/mesos.proto --- @@ -205,9 +205,12 @@ message MachineInfo { * Describes a framework. */ message FrameworkInfo { -

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread ktf
Github user ktf commented on the issue: https://github.com/apache/mesos/pull/141 Hopefully improved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] mesos issue #141: Fix FrameworkInfo::user documentation

2016-07-15 Thread Gilbert88
Github user Gilbert88 commented on the issue: https://github.com/apache/mesos/pull/141 Thanks for the clarification @ktf . This patch LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: Validate lamba function in `Flags::add` for required parameters

2016-07-15 Thread Michael Park
I'm shepherding https://issues.apache.org/jira/browse/MESOS-3335, and I'm hoping to we don't run into too much conflicts here in terms of rebasing and such. Do you guys have anything concrete at this point and a shepherd who will help you guys with this stuff? If not, I'm up to shepherding it, but

Re: Registering and framework failover

2016-07-15 Thread Vinod Kone
As Neil mentioned, we plan to add error codes for asynchronous errors (error() callback in the old API, Error event in the new API) and synchronous errors (HTTP 4xx/5xx responses in the new API). Having said that, I would advise against adding logic in your framework to do something smart (like re

Helper Functions and Code Readability

2016-07-15 Thread Benjamin Mahler
I was reviewing code and noticed the following helper in the allocator benchmarks [1]: // This returns a `Labels` that has 12 key-value pairs, which should // be more than we expect most frameworks to use in practice. We // ensure that the first 11 key-value pairs are equal, which resu

Re: [VOTE] Release Apache Mesos 1.0.0 (rc2)

2016-07-15 Thread tommy xiao
+1 Tested on Fedora release 23 (Twenty Three) - make check - 1.0.0-rc2 2016-07-15 23:01 GMT+08:00 haosdent : > +1 > > Tested on CentOS 7. > > - sudo make check > - upgrade from 0.28.2 to 1.0.0-rc2 > > On Fri, Jul 15, 2016 at 7:47 PM, Alex Rukletsov > wrote: > >> Haosdent investigated the issue