Re: Order of includes

2016-12-13 Thread Benjamin Bannier
Hi Yan, I don’t feel too strongly about most of our style rules regarding include ordering since they are just about style. > For a cpp file foo.cpp, our style guide instructs folks to put the header > foo.hpp at the top of the include list: > https://github.com/apache/mesos/blob/master/docs/c

Re: Question about mesos authentication and authorization?

2016-12-13 Thread Yu Wei
Hi Greg, Thanks for the information. Jared From: Greg Mann Sent: Wednesday, December 14, 2016 9:18:53 AM To: dev Subject: Re: Question about mesos authentication and authorization? Hi Jared, The default authenticator modules included with Mesos only support s

Re: [webui] Started show wrong time

2016-12-13 Thread haosdent
Hi, @Tomek. Thank you for your report. Create a ticket at https://issues.apache.org/jira/browse/MESOS-6790, feel free to post a patch if you have idea for it. On Wed, Dec 14, 2016 at 7:25 AM, Alex Rukletsov wrote: > This looks like a bug. Tomek, could you please file a JIRA? > > On Tue, Dec 13,

Re: Order of includes

2016-12-13 Thread haosdent
> "treat foo.hpp the same way as other project headers". +1 This one may more easily to follow. > 1) If you rely on symbols from bar.h, don't count on the fact that you > included foo.h which (currently) includes bar.h: include bar.h yourself, > 2) unless foo.h explicitly demonstrates its intent

Re: Order of includes

2016-12-13 Thread Yan Xu
Another related practice we should standardize is that, Google style guide suggests here : 1) If you rely on symbols from bar.h, don't count on the fact that you included foo.h which (currently) includes bar.h: include

Order of includes

2016-12-13 Thread Yan Xu
For a cpp file foo.cpp, our style guide instructs folks to put the header foo.hpp at the top of the include list: https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#order-of-includes This is consistent with Google style guide but in reality most of the our files follow the rul

Re: Question about mesos authentication and authorization?

2016-12-13 Thread Greg Mann
Hi Jared, The default authenticator modules included with Mesos only support storing the credentials in a file on disk. However, Mesos exposes an authenticator module interface which can be used to implement more complex authentication scenarios. Note that there are authenticator module interfaces

Re: [webui] Started show wrong time

2016-12-13 Thread Alex Rukletsov
This looks like a bug. Tomek, could you please file a JIRA? On Tue, Dec 13, 2016 at 1:02 PM, Tomek Janiszewski wrote: > Hi > > When task has enabled Mesos healthcheck start time in UI can show wrong > time. This happens because UI assumes that first status is task started > [0]. This is not alwa

Re: Quota

2016-12-13 Thread Vijay Srinivasaraghavan
Hi Alex, >>Granularity in the allocator is a single agent. Does this mean if I have only one agent and the moment if I set any quota, the framework running on the agent will not be allocated with any resource? >From the logs, I don't get to see much details for the scenario when the quota >is set

Re: Command healthcheck failed but status KILLED

2016-12-13 Thread Gastón Kleiman
On Mon, Dec 12, 2016 at 12:47 PM, Tomek Janiszewski wrote: > It there any information that kill is the result of failed healthcheck? > TaskHealthStatus should have some details on what was wrong. When default > executor is killing task it should add a reason and details to TaskStatus. > What do y

[webui] Started show wrong time

2016-12-13 Thread Tomek Janiszewski
Hi When task has enabled Mesos healthcheck start time in UI can show wrong time. This happens because UI assumes that first status is task started [0]. This is not always true because Mesos keeps only recent tasks statuses [1] so when healthcheck updates tasks status it can override task start tim