Github user pleia2 commented on the issue:
https://github.com/apache/mesos/pull/256
Being more familiar with Gerrit than GitHub with forks, I may have made a
bit of a mess here, LMK if you want me to untangle this further or create a new
PR, but I think it's generally where we need to
Github user pleia2 commented on a diff in the pull request:
https://github.com/apache/mesos/pull/256#discussion_r161921933
--- Diff: docs/app-framework-development-guide.md ---
@@ -91,13 +91,13 @@ virtual void offerRescinded(SchedulerDriver* driver,
const OfferID& offerId);
*
Github user pleia2 commented on a diff in the pull request:
https://github.com/apache/mesos/pull/256#discussion_r161922006
--- Diff: docs/endpoints/files/browse.json.md ---
@@ -20,7 +20,7 @@ Query parameters:
### AUTHENTICATION ###
-This endpoint requires authen
If the module needs to detect the same master as the agent does, I think
this feature can be implemented as a module hook.
On Tue, Jan 16, 2018 at 1:48 PM, Benjamin Mahler wrote:
> Just a note that if you increase the number of instances of detectors you
> wind up increasing the number of instan
On the agenda so far, we'll have Meng Zhu present some recent benchmark
findings that compare the performance of the v0, v1 (protobuf / json)
master APIs.
There have also been some initial discussions into streaming state into a
different actor and/or using a filter language like GraphQL to reduce
Just a note that if you increase the number of instances of detectors you
wind up increasing the number of instances of our `Zookeeper` client class.
This class was written a long time ago and so is still a blocking interface
rather than a Future-based non-blocking interface. As a result, the minim
That's correct. The number of watchers here would be doubled. Also, note
that the agent `MasterDetector` is actually checking the leader amongst the
`overlay-master` modules and not the Mesos master itself. Since these are
anonymous modules there is no way to share the slave/masters objects with
th
Hi Avinash,
Thanks for the pointer. A quick scan seems to suggest that your
implementation requires it to create two different instances of
`MasterDetector`, one for master/agent itself, and one for your module.
That probably means number of watchers on zookeeper would be doubled? Would
that creat
Github user greggomann commented on the issue:
https://github.com/apache/mesos/pull/255
@nhandler similar to Vinod's comment: I think we could probably get away
without the heredoc notation, to get rid of the EOFs?
i.e.:
```
curl -i \
-X POST http://:5050/api/v1
Hi Zhitao,
We actually do this in the `DC/OS` overlay modules we use in DC/OS. The
overlay modules run as Mesos modules both in the Master and the Agent. You
can see how we use the `MasterDetector` in the agent module:
https://github.com/dcos/dcos-mesos-modules/blob/master/overlay/agent.cpp#L74
h
Hi,
Some of our future development work on our custom modules requires them to
know the current leader of Mesos master. While it seems like we could
duplicate the logic in master/slave side to duplicate an instance of
`MasterDetector`, it seems more natural if we could figure out a clean way
to sh
11 matches
Mail list logo
