---
On Feb. 18, 2015, 5:27 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31162
On Feb. 18, 2015, 5:42 p.m., Jie Yu wrote:
include/mesos/authentication/authentication.hpp, lines 25-27
https://reviews.apache.org/r/31162/diff/1/?file=868264#file868264line25
We don't do using namespace in headers.
Kapil Arya wrote:
Yes, but this was to avoid changing
-framework.
The tests succeed when src/test-framework is running from the same version as
the slave. However, if I run src/test-framework from the master version, it
doesn't succeed and errors out with unexpected TASK_LOST. Not sure if this is
the desired behavior.
Thanks,
Kapil Arya
://reviews.apache.org/r/31162/diff/
Testing (updated)
---
make check.
Also tested with master running HEAD with this patch, and slave running 0.21.0
with src/test-framework.
Thanks,
Kapil Arya
/#comment118389
Same as the parent diff. Need to modify executorInfo before calling the
next hook.
- Kapil Arya
On Feb. 12, 2015, 8:13 p.m., Niklas Nielsen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
the labels as
well?
src/hook/manager.cpp
https://reviews.apache.org/r/30961/#comment118387
Since we are doing a CopyFrom, shouldn't we be updating taskInfo with the
updated labels. Otherwise, with the current logic, we'll get labels from the
last hook only.
- Kapil Arya
On Feb. 12, 2015, 8
On Feb. 12, 2015, 8:24 p.m., Kapil Arya wrote:
Is the idea here to allow the label decorator hooks to remove the labels as
well?
Don't we also want the label removal facility in the slave instead of the
master? It doesn't make much sense to remove labels in the master.
- Kapil
://reviews.apache.org/r/29947/#review71946
---
On Jan. 27, 2015, 7:39 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org
.
Diffs
-
src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49
Diff: https://reviews.apache.org/r/29607/diff/
Testing
---
Verified that the files are not installed after a 'make install'.
Thanks,
Kapil Arya
/29607/#review71832
---
On Feb. 10, 2015, 2:03 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29607
, and
libexamplemodule) are
needed for Mesos test suite only.
Diffs (updated)
-
src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49
Diff: https://reviews.apache.org/r/29607/diff/
Testing
---
Verified that the files are not installed after a 'make install'.
Thanks,
Kapil Arya
only.
Diffs (updated)
-
src/Makefile.am fae36ac2d539a9aa4c7cd0035275ff6b9260ea49
Diff: https://reviews.apache.org/r/29607/diff/
Testing
---
Verified that the files are not installed after a 'make install'.
Thanks,
Kapil Arya
/messages/messages.hpp 77840bc6a7dfac7ff17ae11f247a3f77d055b481
src/slave/state.cpp d0d7eba88f21bcb4e5808bebe9ab79b27d2f0325
src/tests/registrar_tests.cpp 3d71233f545088cf38b20f51092e3aea103e7352
Diff: https://reviews.apache.org/r/29780/diff/
Testing
---
make check.
Thanks,
Kapil Arya
a54f20d49fed1dd5a740f9b9a0a48d43e79d05e0
src/tests/registrar_tests.cpp 3d71233f545088cf38b20f51092e3aea103e7352
src/tests/state_tests.cpp 4a216e6e3172b6d44087f86e030e5970450a8994
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
2e113be2a48290fb862b04022f38458b4612ab26
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
://reviews.apache.org/r/29606/diff/
Testing
---
make check
Thanks,
Kapil Arya
c594f3f3225a0875de932258821e14f4ca011f02
src/tests/fault_tolerance_tests.cpp c811873eedc90d4ad2d30952a3ac1abedea65cdc
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
src/hook/manager.cpp c14dcca09903d0f724055a9099e1b99d9a0a917b
src/module/hook.hpp c7edfba5ffd33449f01108133f85a33f04d3550e
Diff: https://reviews.apache.org/r/30052/diff/
Testing
---
make check
Thanks,
Kapil Arya
93537d17d3c7604a8532ee1453e405630c481ddc
Diff: https://reviews.apache.org/r/29607/diff/
Testing
---
Verified that the files are not installed after a 'make install'.
Thanks,
Kapil Arya
/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/containerizer.cpp
fa40d47aee7803833bcde6cce1e86a21d7cf27d0
src/tests/isolator_tests.cpp 093b9fd97c28efc008e790346f4cffa7a05ca275
src/tests/module_tests.cpp 2e113be2a48290fb862b04022f38458b4612ab26
Diff: https://reviews.apache.org/r/29604/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
make check.
Thanks,
Kapil Arya
b3aafe4efa9f3469d7a3fd39243ad66b46d6a54d
src/slave/containerizer/mesos/containerizer.cpp
fa40d47aee7803833bcde6cce1e86a21d7cf27d0
src/tests/isolator.hpp 7c40f3cb419057c91b307f164edcdb724d45c50d
Diff: https://reviews.apache.org/r/30338/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/#comment117186
Do we have it in our style sheet to not use two spaces when followed by a
period. Some people prefer two spaces to one space :-).
- Kapil Arya
On Feb. 6, 2015, 9:59 a.m., Alexander Rukletsov wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30295/#review71287
---
On Feb. 4, 2015, 10:15 p.m., Kapil Arya wrote
/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/posix.hpp
7a667e3e30712b98484947520b58965d3b768659
src/slave/containerizer/isolators/posix/disk.hpp
cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732
Diff: https://reviews.apache.org/r/29597/diff/
Testing
---
make check
Thanks,
Kapil Arya
: https://reviews.apache.org/r/30300/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/
Testing
---
make check.
Thanks,
Kapil Arya
d5d788c32ef9d4e9434401464ed1c549b4559b38
src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
93537d17d3c7604a8532ee1453e405630c481ddc
Diff: https://reviews.apache.org/r/29607/diff/
Testing
---
Verified that the files are not installed after a 'make install'.
Thanks,
Kapil Arya
facf6d3e68e412897a1381d7bbdcceaf5d1fbb94
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
f927d4ae9577aff2dd0ba54f1f4b5dd81e815667
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/
Testing
---
make check.
Thanks,
Kapil Arya
aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7
src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e
src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb
Diff: https://reviews.apache.org/r/30052/diff/
Testing
---
make check
Thanks,
Kapil Arya
/messages/messages.hpp 77840bc6a7dfac7ff17ae11f247a3f77d055b481
src/slave/state.cpp 72191ee63f826a1a53d811fed357658f5360132e
src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f
Diff: https://reviews.apache.org/r/29780/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
Diff: https://reviews.apache.org/r/29604/diff/
Testing
---
make check
Thanks,
Kapil Arya
/diff/
Testing
---
make check
Thanks,
Kapil Arya
/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
Diff: https://reviews.apache.org/r/29604/diff/
Testing
---
make check
Thanks,
Kapil Arya
/diff/
Testing
---
make check
Thanks,
Kapil Arya
f927d4ae9577aff2dd0ba54f1f4b5dd81e815667
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/30338/diff/
Testing
---
make check.
Thanks,
Kapil Arya
6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
0f6cc41d60a2e3bc2121cc438351135541ef99ba
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
---
make check.
Thanks,
Kapil Arya
On Jan. 23, 2015, 5:42 p.m., Timothy St. Clair wrote:
configure.ac, line 260
https://reviews.apache.org/r/29595/diff/3/?file=819045#file819045line260
Do you have system details?
Could you provide ldd and version of the system in question.
Kapil Arya wrote:
BTW
/#comment116023
Let's update the comment to mention that the label will be hidden from
web-ui only and then let's add a TODO here about hiding it more generically,
i.e. from third-party hooks, etc.
- Kapil Arya
On Jan. 29, 2015, 5:30 p.m., Niklas Nielsen wrote
0f6cc41d60a2e3bc2121cc438351135541ef99ba
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
: https://reviews.apache.org/r/30300/diff/
Testing
---
make check.
Thanks,
Kapil Arya
src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e
src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb
Diff: https://reviews.apache.org/r/30052/diff/
Testing
---
make check
Thanks,
Kapil Arya
/fault_tolerance_tests.cpp e0065b3a89b9af27c5584bcfdd8c790814bf1af6
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
://reviews.apache.org/r/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
src/slave/flags.hpp a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
? Do we have a preference one way or the other? That way, we
won't have to construct the expect json ourselves.
src/tests/slave_tests.cpp
https://reviews.apache.org/r/30428/#comment115459
Same as above -- add a third test with `hidden` set to false.
- Kapil Arya
On Jan. 29, 2015, 5:30
b6e73d7f500931dec69f115e554f9cd7cb42c3ed
Diff: https://reviews.apache.org/r/30295/diff/
Testing
---
make check.
Thanks,
Kapil Arya
As Dominic pointed out, if the framework writers are not going to use the
headers, then it doesn't make much sense to create a hierarchy for
internal module-specific stuff at this point.
On Tue, Jan 27, 2015 at 2:12 PM, Kapil Arya ka...@mesosphere.io wrote:
On Tue, Jan 27, 2015 at 10:28 AM
On Jan. 23, 2015, 5:38 p.m., Timothy St. Clair wrote:
3rdparty/libprocess/configure.ac, line 178
https://reviews.apache.org/r/30048/diff/1/?file=825235#file825235line178
maybe I'm missing something, but isn't 'test -d' to check directories?
Kapil Arya wrote:
Yeah, that's
?
For modules, I am wondering can we separate Mesos public headers (in
include/mesos right now) from those headers that are only for
building
modules (more like internal public headers).
Thoughts?
- Jie
On Mon, Jan 26, 2015 at 12:35 PM, Kapil Arya ka...@mesosphere.io
bb1779fd644a33527068868a45cf9c19d7732727
src/slave/containerizer/mesos/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
Diff: https://reviews.apache.org/r/30338/diff/
Testing
---
make check.
Thanks,
Kapil Arya
.
Thanks,
Kapil Arya
fca83b3977b95ddda30f9830da10e124b5c605e6
src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52
Diff: https://reviews.apache.org/r/30339/diff/
Testing
---
make check
Thanks,
Kapil Arya
04fd43eb3eacae0d850dd7f4e191116d20620f10
src/tests/hook_tests.cpp 44f73effdce2d03627215418007ccbc3263a0c52
Diff: https://reviews.apache.org/r/29947/diff/
Testing
---
make check
Thanks,
Kapil Arya
/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
Diff: https://reviews.apache.org/r/30338/diff/
Testing
---
make check.
Thanks,
Kapil Arya
://reviews.apache.org/r/29602/diff/
Testing
---
make check
Thanks,
Kapil Arya
to RunState.
- Kapil
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237/#review69676
---
On Jan. 26, 2015, 10:17 p.m., Kapil Arya wrote
,
Kapil Arya
bb1779fd644a33527068868a45cf9c19d7732727
src/slave/containerizer/mesos/containerizer.cpp
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214
Diff: https://reviews.apache.org/r/30338/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e
src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb
Diff: https://reviews.apache.org/r/30052/diff/
Testing
---
make check
Thanks,
Kapil Arya
/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101
Diff: https://reviews.apache.org/r/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
77840bc6a7dfac7ff17ae11f247a3f77d055b481
src/slave/state.cpp 72191ee63f826a1a53d811fed357658f5360132e
src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f
Diff: https://reviews.apache.org/r/29780/diff/
Testing
---
make check.
Thanks,
Kapil Arya
://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
e0065b3a89b9af27c5584bcfdd8c790814bf1af6
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
---
make check
Thanks,
Kapil Arya
d712278428889ebdfd598537690138329d8464f0
src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8
src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc
Diff: https://reviews.apache.org/r/29604/diff/
Testing
---
make check
Thanks,
Kapil Arya
/r/29603/diff/
Testing
---
make check.
Thanks,
Kapil Arya
. To reply, visit:
https://reviews.apache.org/r/30294/#review69769
---
On Jan. 26, 2015, 8:25 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/whitelist_watcher.cpp b6e73d7f500931dec69f115e554f9cd7cb42c3ed
Diff: https://reviews.apache.org/r/30295/diff/
Testing
---
make check.
Thanks,
Kapil Arya
public headers).
Thoughts?
- Jie
On Mon, Jan 26, 2015 at 12:35 PM, Kapil Arya ka...@mesosphere.io
wrote:
Hi All,
TLDR: We currently use mesos::internal namespace for almost
everything
inside src/. However, in most cases, it is directly enclosing another
namespace
---
On Jan. 23, 2015, 9:38 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237/
---
(Updated Jan. 23
Hi All,
TLDR: We currently use mesos::internal namespace for almost everything
inside src/. However, in most cases, it is directly enclosing another
namespace. This makes the internal namespace redundant and we should
kill it.
I learned from Ben Hindman that the original motivation for
://reviews.apache.org/r/30237/#review69676
---
On Jan. 23, 2015, 9:38 p.m., Kapil Arya wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30237
6bfb679d6ab07143f9c77b8cd9719a36d363645f
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/29781/diff/
Testing
---
make check.
Thanks,
Kapil Arya
a27c3e955ff25b87599af0ac2c97427a88b786f6
src/slave/state.hpp de631fb2c8a8d2bcbb861c438b18141ba6211024
Diff: https://reviews.apache.org/r/30238/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/
Testing
---
make check
Thanks,
Kapil Arya
/
Testing
---
make check.
Thanks,
Kapil Arya
ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/30300/diff/
Testing
---
make check.
Thanks,
Kapil Arya
/isolators/posix.hpp
7a667e3e30712b98484947520b58965d3b768659
src/slave/containerizer/isolators/posix/disk.hpp
cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732
Diff: https://reviews.apache.org/r/29597/diff/
Testing
---
make check
Thanks,
Kapil Arya
the current file layout, files in mesos/module/ #include files from mesos/.
For example, mesos/module/isolator.hpp #includes mesos/slave/isolator.hpp.
Is there an alternate file layout suggestion that we should think about?
Thoughts?
- Jie
On Mon, Jan 26, 2015 at 12:35 PM, Kapil Arya ka
PS: I have created a Jira and have published the following RRs:
1. https://reviews.apache.org/r/30294/
2. https://reviews.apache.org/r/30295/
3. https://reviews.apache.org/r/30300/
On Tue, Jan 27, 2015 at 1:50 AM, Kapil Arya ka...@mesosphere.io wrote:
Hi Jie,
Thanks for the comments. I have
/messages/messages.hpp 77840bc6a7dfac7ff17ae11f247a3f77d055b481
src/slave/state.cpp 72191ee63f826a1a53d811fed357658f5360132e
src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f
Diff: https://reviews.apache.org/r/29780/diff/
Testing
---
make check.
Thanks,
Kapil
a3c5c68a553b1c88ce6d5177e625079f7cdb2e5f
Diff: https://reviews.apache.org/r/29598/diff/
Testing
---
make check
Thanks,
Kapil Arya
://reviews.apache.org/r/30294/diff/
Testing
---
make check.
Thanks,
Kapil Arya
15071c2a1084de40f12fe0181a6e2e26baafa8e4
src/state/storage.hpp a36a93e3d509478f30e4ed16a01b3a6a0ffc652e
src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e
Diff: https://reviews.apache.org/r/30300/diff/
Testing
---
make check.
Thanks,
Kapil Arya
e0065b3a89b9af27c5584bcfdd8c790814bf1af6
Diff: https://reviews.apache.org/r/29605/diff/
Testing
---
make check.
Thanks,
Kapil Arya
aadc17aa8f56f8f6ae23ed427cd344f07f7db0c7
src/hook/manager.cpp 6bf1ef7bdddee78a0fab1a942aa89edfd9eb719e
src/module/hook.hpp a7c51f2f46d075a291b2f8e980ae87fd4eee26bb
Diff: https://reviews.apache.org/r/30052/diff/
Testing
---
make check
Thanks,
Kapil Arya
201 - 300 of 802 matches
Mail list logo
