Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

2014-09-25 Thread Patrick Reilly
5bbf829 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 Diff: https://reviews.apache.org/r/25191/diff/ Testing --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-09-10 Thread Patrick Reilly
://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-09-09 Thread Patrick Reilly
://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

2014-09-05 Thread Patrick Reilly
silencing the compiler warnings. Diffs - 3rdparty/libprocess/src/process.cpp 3ac56c7 3rdparty/libprocess/src/subprocess.cpp 5b92200 Diff: https://reviews.apache.org/r/25192/diff/ Testing --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-04 Thread Patrick Reilly
--- In progress. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-09-04 Thread Patrick Reilly
) --- This now implements isolation at the read / write level, using both iops or kbps. Tests for both are also included. Thanks, Patrick Reilly

Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/unreachable.hpp 3568886 Diff: https://reviews.apache.org/r/25191/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
3ac56c7 3rdparty/libprocess/src/subprocess.cpp 5b92200 Diff: https://reviews.apache.org/r/25192/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Review Request 25193: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/log/network.hpp fc85a57 src/slave/containerizer/mesos/launch.cpp 9819381 src/tests/routing_tests.cpp 10730ad src/zookeeper/zookeeper.cpp 72c9fc3 Diff: https://reviews.apache.org/r/25193/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25193: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/25193/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-29 Thread Patrick Reilly
/slave_tests.cpp 69be28f Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/sendfile.hpp 5607896 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 Diff: https://reviews.apache.org/r/25191/diff/ Testing (updated) --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
the compiler warnings. Diffs - 3rdparty/libprocess/src/process.cpp 3ac56c7 3rdparty/libprocess/src/subprocess.cpp 5b92200 Diff: https://reviews.apache.org/r/25192/diff/ Testing (updated) --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25193: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
) --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25191: Switch [stout] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/3rdparty/stout/include/stout/os/sendfile.hpp 5607896 3rdparty/libprocess/3rdparty/stout/include/stout/unreachable.hpp 3568886 Diff: https://reviews.apache.org/r/25191/diff/ Testing --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25192: Switch [libprocess] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
something while still silencing the compiler warnings. Diffs - 3rdparty/libprocess/src/process.cpp 3ac56c7 3rdparty/libprocess/src/subprocess.cpp 5b92200 Diff: https://reviews.apache.org/r/25192/diff/ Testing --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25193: Switch [mesos] to using compiler intrinsics for unreachable, exit, and abort

2014-08-29 Thread Patrick Reilly
/25193/diff/ Testing --- Make check runs. Thanks, Patrick Reilly

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-29 Thread Patrick Reilly
/path_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check created path_tests unit test. Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-29 Thread Patrick Reilly
69be28f Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-29 Thread Patrick Reilly
PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 src/tests/isolator_tests.cpp c38f876 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-08-28 Thread Patrick Reilly
to help.cpp Diffs (updated) - 3rdparty/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
://reviews.apache.org/r/25111/#review51753 --- On Aug. 28, 2014, 4:42 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
--- On Aug. 28, 2014, 4:42 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-28 Thread Patrick Reilly
: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Review Request 25167: Switch to using compiler intrinsics for unreachable, exit, and abort

2014-08-28 Thread Patrick Reilly
/zookeeper.cpp 72c9fc3 Diff: https://reviews.apache.org/r/25167/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25167: Switch to using compiler intrinsics for unreachable, exit, and abort

2014-08-28 Thread Patrick Reilly
., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25167/ --- (Updated Aug. 28, 2014, 10:21 p.m.) Review request

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-08-27 Thread Patrick Reilly
/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly

Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-08-27 Thread Patrick Reilly
--- On Aug. 27, 2014, 6:10 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25079/ --- (Updated Aug. 27

Re: Review Request 25079: Replaced macro expansion with variadic template

2014-08-27 Thread Patrick Reilly
/libprocess/Makefile.am edbe54b 3rdparty/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
/slave/slave.hpp 9d4607e src/slave/slave.cpp 6253a5d Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/#review51680 --- On Aug. 27, 2014, 7:48 p.m., Patrick Reilly wrote

Review Request 25121: Try to give a hint as to what might have gone wrong

2014-08-27 Thread Patrick Reilly
, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
/common/attributes.cpp aab114e src/master/master.hpp c9f989a src/master/master.cpp 2508b38 src/slave/slave.hpp 9d4607e src/slave/slave.cpp 5c76dd1 Diff: https://reviews.apache.org/r/25111/diff/ Testing --- This is currently a work in progress, (WIP) Thanks, Patrick Reilly

Re: Review Request 25111: Added the concept of dynamically configurable slave attributes

2014-08-27 Thread Patrick Reilly
--- On Aug. 27, 2014, 9:28 p.m., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25111/ --- (Updated Aug. 27, 2014

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
/isolators/cgroups/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
/blkio.hpp PRE-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
., Patrick Reilly wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/ --- (Updated Aug. 28, 2014, 12:27 a.m.) Review request

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
-CREATION src/slave/containerizer/isolators/cgroups/blkio.cpp PRE-CREATION src/slave/containerizer/mesos/containerizer.cpp 5116b14 Diff: https://reviews.apache.org/r/25105/diff/ Testing --- In progress. Thanks, Patrick Reilly

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-27 Thread Patrick Reilly
PRE-CREATION Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check created path_tests unit test. Thanks, Patrick Reilly

Re: Review Request 25105: Explore disk io isolation in cgroups

2014-08-27 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25105/#review51730 --- On Aug. 28, 2014, 1:12 a.m., Patrick Reilly wrote

Review Request 25075: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
/stout/path.hpp bc6920a Diff: https://reviews.apache.org/r/25075/diff/ Testing --- Ran make check working on creating a new unit test. Thanks, Patrick Reilly

Re: new contributor

2014-08-26 Thread Patrick Reilly
Hello Niklas, Could you go ahead and add me as well. Probably worth adding the whole Orly team as well. — Patrick On Tue, Aug 26, 2014 at 2:15 PM, Niklas Nielsen nik...@mesosphere.io wrote: Hi Jason, I added you to the JIRA Mesos contributor list. Cheers, Niklas On 26 August 2014

Review Request 25079: Replaced macro expansion with variadic template

2014-08-26 Thread Patrick Reilly
/libprocess/include/process/help.hpp 4333b5b 3rdparty/libprocess/src/help.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25079/diff/ Testing --- Ran make check. Thanks, Patrick Reilly

Re: new contributor

2014-08-26 Thread Patrick Reilly
Hello Niklas, It's jmlvanre, mcypark and cmaloney. — Patrick On Tue, Aug 26, 2014 at 2:27 PM, Niklas Nielsen nik...@mesosphere.io wrote: Patrick, added you already - can you share the jira handles of the other folks? Niklas On 26 August 2014 14:25, Jason jasonl9...@gmail.com wrote:

Re: Review Request 25075: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
) - 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp bc6920a Diff: https://reviews.apache.org/r/25075/diff/ Testing --- Ran make check working on creating a new unit test. Thanks, Patrick Reilly

Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
/stout/path.hpp bc6920a Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check working on creating a new unit test. Thanks, Patrick Reilly

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
/3rdparty/stout/tests/path_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check working on creating a new unit test. Thanks, Patrick Reilly

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
bc6920a 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp PRE-CREATION Diff: https://reviews.apache.org/r/25084/diff/ Testing --- Ran make check working on creating a new unit test. Thanks, Patrick Reilly