Re: Review Request 13606: Added a Top abstraction to the webui.

2014-01-20 Thread Thomas Rampelberg
On Jan. 17, 2014, 6:24 p.m., Thomas Rampelberg wrote: src/webui/master/static/js/services.js, line 110 https://reviews.apache.org/r/13606/diff/2/?file=423536#file423536line110 This could be something like: _.each([ 'cpus_user_time_secs' ], function(n) { this[n

Re: Review Request 13606: Added a Top abstraction to the webui.

2014-01-17 Thread Thomas Rampelberg
and frameworks (doing an _.extend on the data) at the same time? - Thomas Rampelberg On Jan. 15, 2014, 2:30 a.m., Ben Mahler wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13606

Re: Review Request 17082: Fixed display of table filter for empty tables

2014-01-17 Thread Thomas Rampelberg
. Repository: mesos-git Description --- Fixed display of table filter for empty tables Diffs - src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd Diff: https://reviews.apache.org/r/17082/diff/ Testing --- Thanks, Thomas Rampelberg

Review Request 17082: Fixed display of table filter for empty tables

2014-01-17 Thread Thomas Rampelberg
display of table filter for empty tables Diffs - src/webui/master/static/directives/tableHeader.html 2acb6c8797e2aa8f8c2093f00ceaa52e22b497fd Diff: https://reviews.apache.org/r/17082/diff/ Testing --- Thanks, Thomas Rampelberg

[jira] [Commented] (MESOS-913) Help endpoint does not work on slaves.

2014-01-15 Thread Thomas Rampelberg (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13872812#comment-13872812 ] Thomas Rampelberg commented on MESOS-913: - It looks like showdown is available

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
.png Thanks, Thomas Rampelberg

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
https://reviews.apache.org/media/uploaded/files/2014/01/14/683a2aee-58ac-4082-a3fe-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png Thanks, Thomas Rampelberg

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png Thanks, Thomas Rampelberg

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png Thanks, Thomas Rampelberg

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
-4c65a39d4647__Screenshot_2014-01-14_12.58.45.png Screenshot 2014-01-14 16.03.29.png https://reviews.apache.org/media/uploaded/files/2014/01/15/439087df-b72b-47b8-baad-c471d667609f__Screenshot_2014-01-14_16.03.29.png Thanks, Thomas Rampelberg

Re: Review Request 16851: Added filtering to all tables.

2014-01-14 Thread Thomas Rampelberg
-c471d667609f__Screenshot_2014-01-14_16.03.29.png Thanks, Thomas Rampelberg

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-13 Thread Thomas Rampelberg
On Jan. 11, 2014, 1:15 a.m., Thomas Rampelberg wrote: src/webui/master/static/index.html, line 25 https://reviews.apache.org/r/16798/diff/3/?file=420395#file420395line25 It looks right to me ... I'm not sure what container was doing previously. Nope, I was wrong. Updated

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-13 Thread Thomas Rampelberg
/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16798/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-13 Thread Thomas Rampelberg
/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16798/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
c729fadd977b551a30484f0765c57432165a3bc0 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-13 Thread Thomas Rampelberg
--- On Jan. 13, 2014, 7:03 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16798

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16787/#review31666 --- On Jan. 13, 2014, 11:42 p.m., Thomas Rampelberg wrote

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
c729fadd977b551a30484f0765c57432165a3bc0 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
c729fadd977b551a30484f0765c57432165a3bc0 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
c729fadd977b551a30484f0765c57432165a3bc0 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
Diff: https://reviews.apache.org/r/16787/diff/ Testing --- File Attachments (updated) Header Sorting https://reviews.apache.org/media/uploaded/files/2014/01/14/e2a2cc9f-de3d-4c3e-977b-35dd28394212__Screenshot_2014-01-13_16.18.30.png Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-13 Thread Thomas Rampelberg
://reviews.apache.org/media/uploaded/files/2014/01/14/3165c796-cd25-47cf-ae78-051d828571e7__Screenshot_2014-01-13_16.22.09.png Thanks, Thomas Rampelberg

Review Request 16851: Added filtering to all tables.

2014-01-13 Thread Thomas Rampelberg
://reviews.apache.org/r/16851/diff/ Testing --- Thanks, Thomas Rampelberg

Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
519847c0de077717c88c4d35804ad40d339d4246 src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
/diff/ Testing --- Thanks, Thomas Rampelberg

[jira] [Commented] (MESOS-900) Paginate all tables in the web UI

2014-01-10 Thread Thomas Rampelberg (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13868268#comment-13868268 ] Thomas Rampelberg commented on MESOS-900: - Created a directive for sortable/pagable

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-10 Thread Thomas Rampelberg
519847c0de077717c88c4d35804ad40d339d4246 src/webui/master/static/slave_framework.html 947bab12eec8c3be5c3893b873b4b6378c8dcbbb src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16798/diff/ Testing --- Thanks, Thomas

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-10 Thread Thomas Rampelberg
ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16798/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
--- On Jan. 11, 2014, 12:18 a.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16787

Re: Review Request 16787: Implemented a table directive that allows for sorting and pagination.

2014-01-10 Thread Thomas Rampelberg
src/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16787/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16798: Updated to bootstrap-3.0.3.

2014-01-10 Thread Thomas Rampelberg
/webui/master/static/slaves.html ef5b66290e65408312dcf1e59221ee9517b37203 Diff: https://reviews.apache.org/r/16798/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-09 Thread Thomas Rampelberg
: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-09 Thread Thomas Rampelberg
--- On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16712/ --- (Updated Jan

Re: Review Request 16715: showing start/stop time for tasks of completed frameworks

2014-01-09 Thread Thomas Rampelberg
-mail. To reply, visit: https://reviews.apache.org/r/16715/#review31461 --- On Jan. 8, 2014, 1:51 a.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail

Re: Review Request 16715: showing start/stop time for tasks of completed frameworks

2014-01-09 Thread Thomas Rampelberg
/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-09 Thread Thomas Rampelberg
/16712/#comment59980 Yup, that's the plan. I'm working on a couple more `m-` prefixed directives right now. - Thomas Rampelberg On Jan. 9, 2014, 10:50 p.m., Thomas Rampelberg wrote: --- This is an automatically generated e-mail

Review Request 16703: saving timestamp state to local storage

2014-01-07 Thread Thomas Rampelberg
ee41b26cbe34117aa80ace90529e5bc67e91f2e7 Diff: https://reviews.apache.org/r/16703/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16703: saving timestamp state to local storage

2014-01-07 Thread Thomas Rampelberg
: https://reviews.apache.org/r/16703/diff/ Testing --- Thanks, Thomas Rampelberg

Review Request 16709: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
ee41b26cbe34117aa80ace90529e5bc67e91f2e7 Diff: https://reviews.apache.org/r/16709/diff/ Testing --- Thanks, Thomas Rampelberg

Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
ee41b26cbe34117aa80ace90529e5bc67e91f2e7 Diff: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
/webui/master/static/slave.html 24e855b8c8b172bf5dec0ba51a22d94cdb0aa257 src/webui/master/static/slaves.html ee41b26cbe34117aa80ace90529e5bc67e91f2e7 Diff: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16715: showing start/stop time for tasks of completed frameworks

2014-01-07 Thread Thomas Rampelberg
. Repository: mesos-git Description --- showing start/stop time for tasks of completed frameworks Diffs - src/webui/master/static/js/controllers.js 1ba84f1716419cd6a8f6607295a3a061323e10f9 Diff: https://reviews.apache.org/r/16715/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
Diff: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
., Thomas Rampelberg wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16712/ --- (Updated Jan. 8, 2014, 1:31 a.m.) Review

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16712: This will make timestamps toggle between relative and absolute values (for easy cut/paste).

2014-01-07 Thread Thomas Rampelberg
: https://reviews.apache.org/r/16712/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16715: showing start/stop time for tasks of completed frameworks

2014-01-07 Thread Thomas Rampelberg
/r/16715/diff/ Testing --- Thanks, Thomas Rampelberg

Re: Review Request 16715: showing start/stop time for tasks of completed frameworks

2014-01-07 Thread Thomas Rampelberg
/diff/ Testing --- Thanks, Thomas Rampelberg

<    1   2