Re: Review Request 24810: Added Resources support to return the port range for the given number of ports.

2014-09-02 Thread Zuyu Zhang
/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43 src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2 Diff: https://reviews.apache.org/r/24810/diff/ Testing --- make check GTEST_FILTER=*ResourcesTest* Thanks, Zuyu Zhang

Re: Review Request 24810: Added Resources support to return the port range for the given number of ports.

2014-08-31 Thread Zuyu Zhang
src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43 src/tests/resources_tests.cpp b5f2e8bdc664f6f49504f131722e554a0fdcebc2 Diff: https://reviews.apache.org/r/24810/diff/ Testing (updated) --- make check GTEST_FILTER=*ResourcesTest* Thanks, Zuyu Zhang

Review Request 24804: Added Resources support to return the port range for the given number of ports

2014-08-18 Thread Zuyu Zhang
--- Thanks, Zuyu Zhang

Review Request 24810: Added Resources support to return the port range for the given number of ports.

2014-08-18 Thread Zuyu Zhang
/ Testing --- Thanks, Zuyu Zhang

Re: Review Request 23704: Fixed header paths for proto files during installation.

2014-07-22 Thread Zuyu Zhang
On July 22, 2014, 9:33 p.m., Dominic Hamon wrote: If anyone is already building C++ frameworks, they'll have an extra include path in their build script after this, with the 'mesos' path included, right? This shouldn't break them as far as I can see. Is that assumption correct? I

Re: Review Request 23561: Fixed the checkpoint configuration bug in example frameworks.

2014-07-19 Thread Zuyu Zhang
/no_executor_framework.cpp 65cccd17d6c8ec49d05498346f97dd28056d9d25 src/examples/test_framework.cpp 34f70dce3865b81b5175fe11fa382a610f61b196 Diff: https://reviews.apache.org/r/23561/diff/ Testing (updated) --- make check on the linux machine. Thanks, Zuyu Zhang

Re: Review Request 23561: Fixed the checkpoint configuration bug in example frameworks.

2014-07-19 Thread Zuyu Zhang
, Zuyu Zhang

Review Request 23561: Fixed the checkpoint configuration bug in example frameworks.

2014-07-16 Thread Zuyu Zhang
65cccd17d6c8ec49d05498346f97dd28056d9d25 src/examples/test_framework.cpp 34f70dce3865b81b5175fe11fa382a610f61b196 Diff: https://reviews.apache.org/r/23561/diff/ Testing --- Done on the linux machine. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-15 Thread Zuyu Zhang
test. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-15 Thread Zuyu Zhang
) [--] 1 test from ExamplesTest (1655 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1669 ms total) [ PASSED ] 1 test. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Zuyu Zhang
] 1 test. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-14 Thread Zuyu Zhang
(), but they are guarded by mutex.lock in src/scheduler/scheduler.cpp, so all the callbacks will be effectively executed serially. If 'framework' is only accessed by these callbacks, you don't need a lock. Zuyu Zhang wrote: Yeah, you are right once we solved the above race condition

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-06 Thread Zuyu Zhang
case ran. (1669 ms total) [ PASSED ] 1 test. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-06 Thread Zuyu Zhang
Hi, This check error is not related to my patch, but a master test. See below for more details: [ RUN ] ExamplesTest.LowLevelSchedulerPthread [ OK ] ExamplesTest.LowLevelSchedulerPthread (6837 ms) ... [ RUN ] MasterTest.KillUnknownTaskSlaveInTransition 2014-07-04

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-03 Thread Zuyu Zhang
. Thanks, Zuyu Zhang

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-03 Thread Zuyu Zhang
) are already synchronized by Mesos. Zuyu Zhang wrote: We do need to protect any shared variables in LowLevelScheduler using scheduler::Mesos, which internally uses process::async() to execute callbacks. For correctness, we only need to protect shared variables accessed by both the main thread

Re: Review Request 23216: Added the low level scheduler example using pthread.

2014-07-02 Thread Zuyu Zhang
--- On July 1, 2014, 11:05 p.m., Zuyu Zhang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23216

Review Request 23216: Added the low level scheduler example using pthread.

2014-07-01 Thread Zuyu Zhang
] ExamplesTest.LowLevelSchedulerPthread [ OK ] ExamplesTest.LowLevelSchedulerPthread (1655 ms) [--] 1 test from ExamplesTest (1655 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1669 ms total) [ PASSED ] 1 test. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-30 Thread Zuyu Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22539/#review47018 --- On June 27, 2014, 12:47 p.m., Zuyu Zhang wrote: --- This is an automatically

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-30 Thread Zuyu Zhang
] 1 test. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-27 Thread Zuyu Zhang
from 1 test case ran. (1684 ms total) [ PASSED ] 1 test. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-26 Thread Zuyu Zhang
) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (1684 ms total) [ PASSED ] 1 test. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-26 Thread Zuyu Zhang
. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example using libprocess

2014-06-26 Thread Zuyu Zhang
] 1 test. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler examples, implemented using libprocess or pthread.

2014-06-21 Thread Zuyu Zhang
total) [ PASSED ] 2 tests. Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example

2014-06-19 Thread Zuyu Zhang
-CREATION src/tests/examples_tests.cpp 34f0233aca3433faba7528ac8c354100b8d3a4f7 src/tests/low_level_scheduler_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example

2014-06-19 Thread Zuyu Zhang
src/tests/low_level_scheduler_test.sh PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang

[jira] [Created] (MESOS-1520) Mesos headers has included stout headers

2014-06-19 Thread Zuyu Zhang (JIRA)
Zuyu Zhang created MESOS-1520: - Summary: Mesos headers has included stout headers Key: MESOS-1520 URL: https://issues.apache.org/jira/browse/MESOS-1520 Project: Mesos Issue Type: Bug

[jira] [Updated] (MESOS-1520) Mesos headers include stout

2014-06-19 Thread Zuyu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zuyu Zhang updated MESOS-1520: -- Summary: Mesos headers include stout (was: Mesos headers has included stout headers) Mesos headers

[jira] [Commented] (MESOS-1504) mesos.pb.h header include is problematic.

2014-06-18 Thread Zuyu Zhang (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036322#comment-14036322 ] Zuyu Zhang commented on MESOS-1504: --- Did you try the following command: $ g++ test.cpp

Re: Review Request 22715: Fixed an include path for installed headers.

2014-06-18 Thread Zuyu Zhang
On June 19, 2014, 2:11 a.m., Benjamin Hindman wrote: I think we need this for scheduler.pb.h and containerizer.pb.h too right? Yes. - Zuyu --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 22539: Add the low level scheduler example

2014-06-16 Thread Zuyu Zhang
Hindman. Changes --- Add customized sync code. Repository: mesos-git Description --- Add the low level scheduler example Diffs (updated) - src/examples/low_level_scheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example

2014-06-16 Thread Zuyu Zhang
and Jie Yu. Repository: mesos-git Description --- Add the low level scheduler example Diffs - src/examples/low_level_scheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang

Re: Review Request 22539: Add the low level scheduler example

2014-06-13 Thread Zuyu Zhang
Hindman. Repository: mesos-git Description --- Add the low level scheduler example Diffs (updated) - src/Makefile.am c91b438 src/examples/low_level_scheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang

Review Request 22538: Add the low level scheduler example

2014-06-12 Thread Zuyu Zhang
Description --- Add the low level scheduler example Diffs - src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd src/examples/low_level_scheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22538/diff/ Testing --- Thanks, Zuyu Zhang

Review Request 22539: Add the low level scheduler example

2014-06-12 Thread Zuyu Zhang
Description --- Add the low level scheduler example Diffs - src/Makefile.am c91b438c3401ff815116d6faab4f0a34bc0fe3fd src/examples/low_level_scheduler.cpp PRE-CREATION Diff: https://reviews.apache.org/r/22539/diff/ Testing --- Thanks, Zuyu Zhang