Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

2014-11-12 Thread Cody Maloney
I'm getting a new warning with this on OS X w/ clang 3.5 which looks like it probably should be addressed (Add parens to call the node function): ../../../mesos_public/3rdparty/libprocess/src/process.cpp:1662:49: warning: address of function 'process::node' will always evaluate to 'true'

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

2014-11-12 Thread Dominic Hamon
thanks for the head's up - it didn't show up in my linux clang build. testing a fix now. On Wed, Nov 12, 2014 at 2:12 PM, Cody Maloney c...@mesosphere.io wrote: I'm getting a new warning with this on OS X w/ clang 3.5 which looks like it probably should be addressed (Add parens to call the

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

2014-11-12 Thread Dominic Hamon
https://reviews.apache.org/r/27932/ On Wed, Nov 12, 2014 at 2:15 PM, Dominic Hamon dha...@twopensource.com wrote: thanks for the head's up - it didn't show up in my linux clang build. testing a fix now. On Wed, Nov 12, 2014 at 2:12 PM, Cody Maloney c...@mesosphere.io wrote: I'm getting a

Re: [1/2] mesos git commit: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

2014-11-12 Thread Dominic Hamon
Landed. Sorry for the noise. On Wed, Nov 12, 2014 at 2:17 PM, Dominic Hamon dha...@twopensource.com wrote: https://reviews.apache.org/r/27932/ On Wed, Nov 12, 2014 at 2:15 PM, Dominic Hamon dha...@twopensource.com wrote: thanks for the head's up - it didn't show up in my linux clang build.