[ https://issues.apache.org/jira/browse/MESOS-1177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Mahler resolved MESOS-1177. ------------------------------------ Resolution: Fixed Fix Version/s: 0.19.0 Assignee: Vinson Lee {noformat} commit c4188341d5a4e6039ba4ed1d8f0549f6bb65d1bc Author: Vinson Lee <v...@freedesktop.org> Date: Mon May 12 12:25:03 2014 -0700 Add a return statement to Varint64Comparator::Compare in leveldb to silence the compiler warning. This patch fixes this build error with ICC. Review: https://reviews.apache.org/r/21292 {noformat} > log/leveldb.cpp(56): error #1011: missing return statement at end of non-void > function "mesos::internal::log::Varint64Comparator::Compare" > ------------------------------------------------------------------------------------------------------------------------------------------ > > Key: MESOS-1177 > URL: https://issues.apache.org/jira/browse/MESOS-1177 > Project: Mesos > Issue Type: Bug > Components: build > Environment: Fedora 19 > icpc (ICC) 14.0.2 20140120 > Reporter: Vinson Lee > Assignee: Vinson Lee > Fix For: 0.19.0 > > > {noformat} > libtool: compile: /opt/intel/bin/icpc -DPACKAGE_NAME=\"mesos\" > -DPACKAGE_TARNAME=\"mesos\" -DPACKAGE_VERSION=\"0.19.0\" > "-DPACKAGE_STRING=\"mesos 0.19.0\"" -DPACKAGE_BUGREPORT=\"\" > -DPACKAGE_URL=\"\" -DPACKAGE=\"mesos\" -DVERSION=\"0.19.0\" -DSTDC_HEADERS=1 > -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 > -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 > -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD=1 > -DMESOS_HAS_JAVA=1 -DHAVE_PYTHON=\"2.7\" -DMESOS_HAS_PYTHON=1 -DHAVE_LIBZ=1 > -DHAVE_LIBCURL=1 -DHAVE_LIBSASL2=1 -I. -Wall -Werror > -DLIBDIR=\"/usr/local/lib\" -DPKGLIBEXECDIR=\"/usr/local/libexec/mesos\" > -DPKGDATADIR=\"/usr/local/share/mesos\" -I../include > -I../3rdparty/libprocess/include > -I../3rdparty/libprocess/3rdparty/stout/include -I../include > -I../3rdparty/libprocess/3rdparty/boost-1.53.0 > -I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src > -I../3rdparty/libprocess/3rdparty/picojson-4f93734 > -I../3rdparty/libprocess/3rdparty/glog-0.3.3/src > -I../3rdparty/leveldb/include -I../3rdparty/zookeeper-3.4.5/src/c/include > -I../3rdparty/zookeeper-3.4.5/src/c/generated -pthread -g -g2 -O2 -MT > log/liblog_la-leveldb.lo -MD -MP -MF log/.deps/liblog_la-leveldb.Tpo -c > log/leveldb.cpp -fPIC -DPIC -o log/.libs/liblog_la-leveldb.o > log/leveldb.cpp(56): error #1011: missing return statement at end of non-void > function "mesos::internal::log::Varint64Comparator::Compare" > } > ^ > {noformat} > src/log/leveldb.cpp > {noformat} > 45 virtual int Compare( > 46 const leveldb::Slice& a, > 47 const leveldb::Slice& b) const > 48 { > 49 // TODO(benh): Use varint comparator. > 50 LOG(FATAL) << "Unimplemented"; > 51 // uint64_t left = position(a); > 52 // uint64_t right = position(b); > 53 // if (left < right) return -1; > 54 // if (left == right) return 0; > 55 // if (left > right) return 1; > 56 } > {noformat} -- This message was sent by Atlassian JIRA (v6.2#6252)