Re: Inconsistent naming of support scripts

2017-01-25 Thread Michael Park
The support scripts have now been renamed by https://github.com/apache/mesos/commit/8b8f4af3c4d70c3ffcb70092da0fb0cd636bbe9a *NOTE*: If your git hooks were *copied* into `.git/hooks` rather than *symlinked*, then you may run into issues. If so, please remove

Re: Inconsistent naming of support scripts

2017-01-13 Thread Michael Park
commit 8b8f4af3c4d70c3ffcb70092da0fb0cd636bbe9a Author: Michael Park Date: Wed Jan 11 14:54:23 2017 -0800 Renamed executable files from '_' to '-' in the `support` directory. Review: https://reviews.apache.org/r/55487 On Fri, Sep 2, 2016 at 1:45 AM, Vinod Kone

Re: Inconsistent naming of support scripts

2016-09-02 Thread Vinod Kone
Nope. Didn't get around to doing it. Feel free to take over. @vinodkone > On Sep 2, 2016, at 8:56 AM, Michael Park wrote: > > Vinod, are there patches out for these? I would like to help close this off. > >> On Tue, Feb 16, 2016 at 6:30 PM, Vinod Kone

Re: Inconsistent naming of support scripts

2016-09-02 Thread Michael Park
Vinod, are there patches out for these? I would like to help close this off. On Tue, Feb 16, 2016 at 6:30 PM, Vinod Kone wrote: > Thanks for the feedback. I'll send out a patch. > > On Tue, Feb 16, 2016 at 9:12 AM, haosdent wrote: > > > >running `find

Re: Inconsistent naming of support scripts

2016-02-16 Thread Vinod Kone
Thanks for the feedback. I'll send out a patch. On Tue, Feb 16, 2016 at 9:12 AM, haosdent wrote: > >running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while `find > /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen for > executables is more

Re: Inconsistent naming of support scripts

2016-02-16 Thread haosdent
>running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while `find /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen for executables is more standard. +1 Same for me. On Wed, Feb 17, 2016 at 1:10 AM, Alexander Rojas wrote: > +1 for

Re: Inconsistent naming of support scripts

2016-02-16 Thread Alexander Rojas
+1 for consistency, +1 for executables. I do enough finger yoga while using emacs! running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while `find /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen for executables is more standard. > On 11 Feb 2016, at 14:58,

Re: Inconsistent naming of support scripts

2016-02-11 Thread Marco Massenzio
+10 for consistency +1 for hyphens (less carpal-tunnel :) -- *Marco Massenzio* http://codetrips.com On Thu, Feb 11, 2016 at 2:58 PM, Michael Park wrote: > +1 for consistency, +1 for hyphens for executables. > > On 11 February 2016 at 14:25, Kevin Klues

Inconsistent naming of support scripts

2016-02-11 Thread Vinod Kone
Some the scripts in the "support" directory have dashes ("-") in their names (e.g., apply-review.sh, apply-reviews.py), whereas some have underscores ("_") (e.g., docker_build.sh, mesos_split.py). This is really confusing and we should stick with one style. I propose to change all them to use

Re: Inconsistent naming of support scripts

2016-02-11 Thread Kevin Klues
I prefer hyphens as well On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese wrote: > hyphen++. Is google friendly apparently. Also less keys to press :) > > -Jojy > > > >> On Feb 11, 2016, at 12:43 PM, Greg Mann wrote: >> >> +1 >> >> On Thu, Feb 11, 2016

Re: Inconsistent naming of support scripts

2016-02-11 Thread Michael Park
+1 for consistency, +1 for hyphens for executables. On 11 February 2016 at 14:25, Kevin Klues wrote: > I typically think of files having dashes as binaries or scripts that > are runnable, whereas files with underscores are meant as source or > otherwise supplementary to the

Re: Inconsistent naming of support scripts

2016-02-11 Thread Greg Mann
+1 On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone wrote: > Some the scripts in the "support" directory have dashes ("-") in their > names (e.g., apply-review.sh, apply-reviews.py), whereas some have > underscores ("_") (e.g., docker_build.sh, mesos_split.py). > > This is

Re: Inconsistent naming of support scripts

2016-02-11 Thread Kevin Klues
I typically think of files having dashes as binaries or scripts that are runnable, whereas files with underscores are meant as source or otherwise supplementary to the binary produced (e.g. a supplementary python library that the main python program imports). I'm not sure where I inherited this

Re: Inconsistent naming of support scripts

2016-02-11 Thread Jojy Varghese
hyphen++. Is google friendly apparently. Also less keys to press :) -Jojy > On Feb 11, 2016, at 12:43 PM, Greg Mann wrote: > > +1 > > On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone wrote: > >> Some the scripts in the "support" directory have

Re: Inconsistent naming of support scripts

2016-02-11 Thread Vinod Kone
Why hyphens? Most of the files in our repo use underscores. I would like us to be consistent on how we name files in the repo. On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues wrote: > I prefer hyphens as well > > On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese