Re: Mesos default build flags

2014-10-23 Thread Cody Maloney
*High-level* The information to print file name, line number of both callsite and definition start is all there. 'glog' doesn't use it though. 'glog' looks up the function name by searching the static and dynamic linking symbol tables in the binary. That is always there unless the binary has been s

Re: Mesos default build flags

2014-10-23 Thread Benjamin Mahler
Fantastic, just one question: Still a bit confused about -g1. From the GCC page, it seems to say that -g1 provides line number tables, is that not the case for the backtraces from glog? Does -g1 have any impact on line numbers within a core dump? https://gcc.gnu.org/onlinedocs/gcc/Debugging-Optio

Re: Mesos default build flags

2014-10-23 Thread Cody Maloney
On Wed, Oct 22, 2014 at 4:09 PM, Dominic Hamon wrote: > Thanks for the thorough breakdown. > > I think we should have -O0 -g1 for a default as people building will be > expecting good backtraces and to be able to run gdb without a recompile. > Packaged builds should enable the release setting (-O

Re: Mesos default build flags

2014-10-22 Thread Dominic Hamon
Thanks for the thorough breakdown. I think we should have -O0 -g1 for a default as people building will be expecting good backtraces and to be able to run gdb without a recompile. Packaged builds should enable the release setting (-O2 -g0) so that end users get the fastest/smallest builds. On Wed

Mesos default build flags

2014-10-22 Thread Cody Maloney
I want to make our standard build flags match what other projects tend to supply. In submitting a patch for this (https://reviews.apache.org/r/26426/), Ben Mahler asked for some numbers as to what effect the different combinations of flags have. Attached in testing_methodology.txt is the steps, bu