Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-23 Thread Timothy St. Clair
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-22 Thread Cody Maloney
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-16 Thread Cody Maloney
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-16 Thread Ben Mahler
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-15 Thread Cody Maloney
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-15 Thread Ben Mahler
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-15 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review56692 --- Ship it! I'll wait a couple of days for any more comments before a

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review56661 --- Patch looks great! Reviews applied: [26426] All tests passed. - M

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Timothy St. Clair
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Timothy St. Clair
> On Oct. 14, 2014, 11:11 p.m., Dominic Hamon wrote: > > configure.ac, line 281 > > > > > > aside: you might want to consider Os for release. It'll keep the size > > down and will often be as performant, even without

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review56598 --- configure.ac

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/ --- (Updated Oct. 14, 2014, 11:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Cody Maloney
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Cody Maloney
> On Oct. 14, 2014, 9:06 p.m., Timothy St. Clair wrote: > > configure.ac, line 281 > > > > > > Is there a reason you want to leave debug symbols out of optimized > > builds? > > > > cmake has the pattern co

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-14 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review56573 --- configure.ac

Re: Review Request 26426: Add --enable-debug flag to ./configure for controlling emission of debug information

2014-10-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26426/#review55742 --- Patch looks great! Reviews applied: [26426] All tests passed. - M