Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

2014-11-14 Thread Benjamin Hindman
On Nov. 12, 2014, 7:07 p.m., Niklas Nielsen wrote: 3rdparty/libprocess/src/process.cpp, line 845 https://reviews.apache.org/r/27509/diff/1/?file=747127#file747127line845 Why do you also need to pass 's' along? couldn't you get that from socket? Yes, but since this code gets

Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

2014-11-14 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 14, 2014, 11:18 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

2014-11-14 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61591 --- Ship it! Ship It! - Niklas Nielsen On Nov. 14, 2014, 3:18 p.m.,

Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

2014-11-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/#review61026 --- LGTM module question below 3rdparty/libprocess/src/process.cpp

Re: Review Request 27509: Used io::poll instead of libev for receiving_connect.

2014-11-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27509/ --- (Updated Nov. 11, 2014, 4:55 p.m.) Review request for mesos, Ben Mahler, Jie