Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

> On April 13, 2015, 1:47 p.m., Ben Mahler wrote: > > src/master/master.hpp, lines 1100-1103 > > > > > > Did you look back at https://reviews.apache.org/r/19176/ when doing > > this? > > > > What was the mot

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79904 --- src/master/master.hpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79799 --- Ship it! Needs a quick rebase before committing. - Adam B On Apr

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated April 7, 2015, 12:59 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review79146 --- LGTM, assuming no significant rebases. src/master/master.hpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

> On April 1, 2015, 2:28 a.m., Adam B wrote: > > src/slave/slave.cpp, line 1043 > > > > > > Hmm... I was actually thinking that this line of code can be removed > > now that you're always filling in the id in the F

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated April 1, 2015, 3:34 p.m.) Review request for mesos, Adam B and Niklas

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

> On April 1, 2015, 5:28 a.m., Adam B wrote: > > src/slave/slave.cpp, line 1043 > > > > > > Hmm... I was actually thinking that this line of code can be removed > > now that you're always filling in the id in the F

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/#review78496 --- src/slave/slave.cpp

Re: Review Request 32585: Replaced Framework.id with Framework.id() in Master/Slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32585/ --- (Updated March 31, 2015, 4:29 p.m.) Review request for mesos, Adam B and Niklas