Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-08 Thread Thomas Marshall
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-505 https://issu

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-15 Thread Thomas Marshall
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/ --- (Updated July 15, 2013, 11:12 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-16 Thread Thomas Marshall
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/ --- (Updated July 17, 2013, 3:39 a.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-18 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/#review23404 --- Ship it! Sweet! src/common/resources.hpp

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-19 Thread Thomas Marshall
> On July 18, 2013, 5:28 p.m., Benjamin Hindman wrote: > > src/master/hierarchical_allocator_process.hpp, lines 723-724 > > > > > > Can you just do: > > > > resources += slaves[slaveId].available.extract(role)

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-19 Thread Thomas Marshall
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/ --- (Updated July 19, 2013, 5:46 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 12343: Reservations 3 - Add reservations to slaves

2013-07-20 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12343/#review23584 --- Ship it! Ship It! - Benjamin Hindman On July 19, 2013, 5:46 p.m.