Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Dec. 17, 2013, 1:22 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Dec. 13, 2013, 5:37 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-12 Thread Jie Yu
> On Dec. 10, 2013, 6:38 a.m., Benjamin Hindman wrote: > > src/log/log.cpp, line 305 > > > > > > When would we want '!strict' with the log? I see you commented on why > > we might not want strict for the replica when

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-10 Thread Jie Yu
> On Dec. 10, 2013, 6:38 a.m., Benjamin Hindman wrote: > > src/log/log.cpp, line 305 > > > > > > When would we want '!strict' with the log? I see you commented on why > > we might not want strict for the replica when

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-10 Thread Jie Yu
> On Dec. 10, 2013, 6:38 a.m., Benjamin Hindman wrote: > > src/log/log.cpp, line 173 > > > > > > Rather than holding on to the LogProcess*, how about we make > > Log::recover() return a Future> and that's how we get t

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-10 Thread Jie Yu
> On Dec. 10, 2013, 6:38 a.m., Benjamin Hindman wrote: > > src/log/log.cpp, line 817 > > > > > > I'd prefer to keep these "timeouts" be of type Timeout not Duration (in > > all these methods). One inconsistency I fou

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/#review29966 --- src/log/log.hpp

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Dec. 5, 2013, 7:28 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Dec. 4, 2013, 8:02 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-12-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Dec. 4, 2013, 1:16 a.m.) Review request for mesos, Benjamin Hindman, B

Re: Review Request 15802: Catch-up Replicated Log 3: Added log recovery support.

2013-11-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15802/ --- (Updated Nov. 25, 2013, 5:55 a.m.) Review request for mesos, Benjamin Hindman,