Re: Review Request 17423: Added log implementation for state storage.

2014-03-10 Thread Benjamin Hindman
> On Jan. 30, 2014, 7:59 p.m., Jie Yu wrote: > > src/state/log.cpp, line 94 > > > > > > We can kill this if the following patch is out: > > https://reviews.apache.org/r/17476/ > > > > Replace it with a Sequ

Re: Review Request 17423: Added log implementation for state storage.

2014-03-10 Thread Benjamin Hindman
> On Jan. 31, 2014, 6:02 p.m., Jie Yu wrote: > > src/state/log.cpp, line 348 > > > > > > "writer.append" could potentially block forever if there is, for > > example, a network blip (i.e. the coordinator will wait for

Re: Review Request 17423: Added log implementation for state storage.

2014-01-31 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/#review9 --- src/state/log.cpp

Re: Review Request 17423: Added log implementation for state storage.

2014-01-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/#review33233 --- Great stuff! src/messages/state.proto

Re: Review Request 17423: Added log implementation for state storage.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/ --- (Updated Jan. 27, 2014, 9:33 p.m.) Review request for mesos, Ben Mahler and Jie

Review Request 17423: Added log implementation for state storage.

2014-01-27 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17423/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Descri