Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-20 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/ --- (Updated Feb. 20, 2014, 8:54 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/#review34924 --- Ship it!

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Charlie Carson
On Feb. 19, 2014, 8:52 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 159 https://reviews.apache.org/r/17520/diff/2/?file=469354#file469354line159 I definitely prefer the SFINAE approach to the last one! Can we make this a default

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/#review34952 --- 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Charlie Carson
On Feb. 20, 2014, 12:14 a.m., Dominic Hamon wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 102 https://reviews.apache.org/r/17520/diff/2/?file=469354#file469354line102 consider making this (and the other single parameter constructors in this file)

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/ --- (Updated Feb. 20, 2014, 12:21 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-19 Thread Benjamin Hindman
On Feb. 19, 2014, 8:52 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp, line 159 https://reviews.apache.org/r/17520/diff/2/?file=469354#file469354line159 I definitely prefer the SFINAE approach to the last one! Can we make this a default

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-04 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/ --- (Updated Feb. 4, 2014, 9:41 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-02-04 Thread Jeff Currier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/#review33643 --- Ship it! Ship It! - Jeff Currier On Feb. 4, 2014, 9:41 p.m.,

Review Request 17520: Add JSON::Boolean to stout/json.hpp.

2014-01-29 Thread Charlie Carson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17520/ --- Review request for mesos, Benjamin Hindman and Jeff Currier. Bugs: