Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-16 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/ --- Review request for mesos, Ben Mahler and Jiang Yan Xu. Bugs: MESOS-1276 htt

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Vinod Kone
> On May 15, 2014, 12:40 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp, lines 891-893 > > > > > > Before the change "duration * 2" is capped by > > "REGISTER_RETRY_INTERVAL_MAX * 2" so it's always safe. > > >

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/#review43067 --- Ship it! The rest looks great! src/slave/slave.cpp

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/#review43057 --- src/slave/constants.hpp

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Vinod Kone
> On May 14, 2014, 10:53 p.m., Jiang Yan Xu wrote: > > src/tests/slave_recovery_tests.cpp, lines 1314-1315 > > > > > > Are ReregisterSlaveMessage -> SlaveReregisteredMessage here and below > > necessary for the backo

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/#review43044 --- src/slave/flags.hpp

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Vinod Kone
> On May 15, 2014, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 559 > > > > > > I think we need to update 'authenticate' to deal with the fact that it > > can now be invoked asynchronously. Namely, it n

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/#review43041 --- src/slave/slave.cpp

Re: Review Request 21464: Added backoff to slave's initial registration/authentication attempt.

2014-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21464/ --- (Updated May 14, 2014, 11:06 p.m.) Review request for mesos, Ben Mahler and Jia