Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44064 --- src/tests/containerizer_tests.cpp

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Till Toenshoff
> On May 27, 2014, 9:48 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 460 > > > > > > could you also correct the string here to "this is stdout". How did this ever work? :) > On May 27, 2014, 9

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44063 --- Ship it! Ship It! - Dominic Hamon On May 27, 2014, 3:42 p.m., Ti

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/ --- (Updated May 27, 2014, 10:42 p.m.) Review request for mesos and Ben Mahler. C

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44050 --- Ship it! Ship It! - Ian Downes On May 22, 2014, 5:47 p.m., Till

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Ian Downes
> On May 27, 2014, 2:48 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 462 > > > > > > Let's change this to use printf, as suggested in `man echo`, to not > > output the \n. > > Dominic Hamon wro

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Dominic Hamon
> On May 27, 2014, 2:48 p.m., Ian Downes wrote: > > src/tests/containerizer_tests.cpp, line 462 > > > > > > Let's change this to use printf, as suggested in `man echo`, to not > > output the \n. looking over the rest

Re: Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-27 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/#review44047 --- src/tests/containerizer_tests.cpp

Review Request 21833: Fixed MesosContainerizerExecuteTest.IoRedirection for OSX.

2014-05-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21833/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1413 https://issues.ap