Re: Review Request 22123: Failover boolean to prevent using large timeout values

2014-07-02 Thread Adam B
On June 26, 2014, 1:39 a.m., Adam B wrote: include/mesos/mesos.proto, line 128 https://reviews.apache.org/r/22123/diff/1/?file=601126#file601126line128 Please add some documentation to the FrameworkInfo comment that explains what a value of failover=true means and when it should

Re: Review Request 22123: Failover boolean to prevent using large timeout values

2014-07-01 Thread Isabel Jimenez
On June 26, 2014, 8:39 a.m., Adam B wrote: include/mesos/mesos.proto, line 128 https://reviews.apache.org/r/22123/diff/1/?file=601126#file601126line128 Please add some documentation to the FrameworkInfo comment that explains what a value of failover=true means and when it should

Re: Review Request 22123: Failover boolean to prevent using large timeout values

2014-06-26 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22123/#review46725 --- Not sure if this review is still going anywhere, but I thought I'd

Re: Review Request 22123: Failover boolean to prevent using large timeout values

2014-06-26 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22123/#review46833 --- src/master/master.cpp

Re: Review Request 22123: Failover boolean to prevent using large timeout values

2014-06-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22123/#review44483 --- Patch looks great! Reviews applied: [22123] All tests passed. -