Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

> On July 7, 2014, 3:03 p.m., Adam B wrote: > > src/master/http.cpp, line 637 > > > > > > Can we get some more descriptive error strings, please? ("Mesos master" > > everywhere may not be descriptive enough when debug

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

> On July 7, 2014, 10:03 p.m., Adam B wrote: > > src/master/http.cpp, lines 622-623 > > > > > > Does this mean that the /shutdown API only works when authentication is > > enabled (or at least credentials are provided

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47417 --- Looks great! I just wonder if we should also allow /shutdown to be c

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47415 --- Ship it! Great! Thanks Isabel! - Benjamin Hindman On July 7, 201

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

> On July 1, 2014, 11:04 p.m., Dominic Hamon wrote: > > src/slave/slave.hpp, line 324 > > > > > > is this change just for symmetry with Master::Http? Yes, this change is just for consistency > On July 1, 2014, 11:04

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/ --- (Updated July 7, 2014, 8:59 p.m.) Review request for mesos, Adam B, Benjamin Hi

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47177 --- Patch looks great! Reviews applied: [22832] All tests passed. - M

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review47156 --- src/Makefile.am

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

> On June 24, 2014, 10:03 a.m., Adam B wrote: > > src/master/master.hpp, line 422 > > > > > > No more const. :( > > Can you give us a quick explanation why? (Master::removeFramework() is > > not const?) No remove

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/ --- (Updated July 1, 2014, 10:46 p.m.) Review request for mesos, Adam B, Benjamin H

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46605 --- Bad patch! Reviews applied: [2, 22825, 22832] Failed command:

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46506 --- Any ideas how this could be extended to handle OAuth or other http

Re: Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/#review46410 --- Can we make 'master' be a pointer in the nested Http class instead o

Review Request 22832: HTTP Authenticated '/shutdown' endpoint

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22832/ --- Review request for mesos, Adam B, Benjamin Hindman, Dominic Hamon, and Till Toen