Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-09-26 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review54697 --- I'm discarding this review and will cleanup the patch, and create a

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-07-14 Thread Timothy St. Clair
> On July 13, 2014, 8:35 a.m., Adam B wrote: > > src/Makefile.am, line 1074 > > > > > > Was this not needed for mesos_tests_CPPFLAGS before? Why is it needed > > now? B4 the tests files actually reconstructed the 3r

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-07-13 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review47693 --- I'm concerned about these zookeeper-3.4.5/lib/* jars, and have a few

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-07-11 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/ --- (Updated July 11, 2014, 4:19 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-06-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review46893 --- Patch looks great! Reviews applied: [22994] All tests passed. - M

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-06-26 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/ --- (Updated June 26, 2014, 7:20 p.m.) Review request for mesos and Benjamin Hindma

Re: Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-06-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/#review46706 --- Patch looks great! Reviews applied: [22994] All tests passed. - M

Review Request 22994: Fixes for zookeeper tests when running --disable-bundled

2014-06-25 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22994/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-1168 https://iss