Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-09-11 Thread Ian Downes
On Aug. 19, 2014, 5:21 p.m., Jie Yu wrote: src/slave/containerizer/isolators/filesystem.cpp, lines 44-46 https://reviews.apache.org/r/24178/diff/1/?file=647967#file647967line44 Check for kernel version? Check for root permission? For example, when bind mount is introduced? bind

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review51046 --- Nice to see this! Added some high level comments. src/Makefile.am

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-19 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review51049 --- src/slave/containerizer/isolators/filesystem.hpp

Review Request 24178: Basic filesystem isolator for Linux.

2014-08-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/ --- Review request for mesos, Ben Mahler and Jie Yu. Bugs: MESOS-1586

Re: Review Request 24178: Basic filesystem isolator for Linux.

2014-08-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24178/#review49383 --- Patch looks great! Reviews applied: [24177, 24178] All tests