Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50772 --- Ship it! Ship It! - Timothy St. Clair On Aug. 15, 2014, 6:58 p.m

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50769 --- Ship it! Ship It! - Vinod Kone On Aug. 15, 2014, 6:58 p.m., Jie

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 6:58 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Jie Yu
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. > > Timothy St. Clair wrote: > why? >

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Vinod Kone
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. > > Timothy St. Clair wrote: > why? >

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 111 > > > > > > should this be --with-http_parser? "_" between http and parser. why? $ sudo yum list | grep http | grep par

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
> On Aug. 15, 2014, 6:05 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/configure.ac, line 425 > > > > > > I'm little confused on what the difference is between PROTOCOMPILER vs > > PROTOBUF_COMPILER vs PROTOC. can w

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50751 --- 3rdparty/libprocess/configure.ac

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 5:19 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- (Updated Aug. 15, 2014, 5:12 p.m.) Review request for mesos, Timothy St. Clair

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote: > > configure.ac, line 283 > > > > > > This needs to be here or else the includes fail on distributions. > > Jie Yu wrote: > Are you saying that I should do:

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Jie Yu
> On Aug. 15, 2014, 2:23 p.m., Timothy St. Clair wrote: > > configure.ac, line 283 > > > > > > This needs to be here or else the includes fail on distributions. Are you saying that I should do: CPPFLAGS="$CPPFLAGS -I

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50722 --- 3rdparty/libprocess/configure.ac

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50719 --- Thanks for all the help guys! & That is an epic configure line ;-)

Re: Review Request 24734: Fixed a few issues in configure.ac.

2014-08-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/#review50708 --- Ship it! LGTM. I'll let Tim give it a look over. - Vinod Kone On

Review Request 24734: Fixed a few issues in configure.ac.

2014-08-14 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24734/ --- Review request for mesos, Timothy St. Clair and Vinod Kone. Repository: mesos-g