Re: Review Request 24776: Add docker containerizer destroy tests

2014-11-03 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Nov. 3, 2014, 8:53 p.m.) Review request for mesos, Benjamin Hindman an

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53781 --- Patch looks great! Reviews applied: [24776] All tests passed. - M

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:22 p.m.) Review request for drill, Benjamin Hindman

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Timothy Chen
> On Sept. 17, 2014, 11:20 p.m., Adam B wrote: > > src/slave/containerizer/docker.cpp, lines 353-358 > > > > > > Why call new DockerContainerizerProcess twice? Oops, bad merge! - Timothy --

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53767 --- src/slave/containerizer/docker.cpp

Re: Review Request 24776: Add docker containerizer destroy tests and modify docker pull

2014-09-17 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 11:11 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53692 --- Bad patch! Reviews applied: [24776] Failed command: git apply --in

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 17, 2014, 12:21 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-16 Thread Benjamin Hindman
> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: > > Why did you need to mock DockerContainerizerProcess in order to write these > > tests? Couldn't you have just used the existing MockDockerContainerizer? > > Timothy Chen wrote: > I wanted to simulate having destroy called in a pull/

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-16 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53535 --- Ship it! LGTM, but as always let's definitely resolve the two issue

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review53418 --- Patch looks great! Reviews applied: [24776] All tests passed. - M

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- (Updated Sept. 15, 2014, 8:33 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-10 Thread Timothy Chen
> On Sept. 9, 2014, 6:15 p.m., Benjamin Hindman wrote: > > Why did you need to mock DockerContainerizerProcess in order to write these > > tests? Couldn't you have just used the existing MockDockerContainerizer? I wanted to simulate having destroy called in a pull/fetching state, so I thought

Re: Review Request 24776: Add docker containerizer destroy tests

2014-09-09 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review52758 --- Why did you need to mock DockerContainerizerProcess in order to writ

Re: Review Request 24776: Add docker containerizer destroy tests

2014-08-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review51751 --- Jie or Ben can you guys commit this? - Timothy Chen On Aug. 16, 2

Re: Review Request 24776: Add docker containerizer destroy tests

2014-08-27 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review51750 --- Jie or Ben can you guys commit this? - Timothy Chen On Aug. 16, 2

Re: Review Request 24776: Add docker containerizer destroy tests

2014-08-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/#review50835 --- Patch looks great! Reviews applied: [24776] All tests passed. - M

Review Request 24776: Add docker containerizer destroy tests

2014-08-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24776/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos-git