Review Request 24825: Fixed a bug in docker/docker.cpp that causes unresolved symbols on OSX.

2014-08-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24825/ --- Review request for mesos, Benjamin Hindman, Timothy Chen, and Vinod Kone.

Re: Review Request 24825: Fixed a bug in docker/docker.cpp that causes unresolved symbols on OSX.

2014-08-18 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24825/#review50943 --- Ship it! src/slave/containerizer/isolators/cgroups/constants.hpp

Re: Review Request 24825: Fixed a bug in docker/docker.cpp that causes unresolved symbols on OSX.

2014-08-18 Thread Jie Yu
On Aug. 19, 2014, 12:28 a.m., Vinod Kone wrote: src/slave/containerizer/isolators/cgroups/constants.hpp, lines 32-37 https://reviews.apache.org/r/24825/diff/1/?file=663830#file663830line32 Shouldn't these be initialized in a .cpp because of the gcc 4.1.2 bug that affected master

Re: Review Request 24825: Fixed a bug in docker/docker.cpp that causes unresolved symbols on OSX.

2014-08-18 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24825/#review50945 --- Ship it! Ship It! - Timothy Chen On Aug. 18, 2014, 11:40 p.m.,

Re: Review Request 24825: Fixed a bug in docker/docker.cpp that causes unresolved symbols on OSX.

2014-08-18 Thread Timothy Chen
On Aug. 19, 2014, 1:13 a.m., Timothy Chen wrote: Ship It! Sorry about this, thanks for fixing this up! - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24825/#review50945