Re: Review Request 24939: Report bind parameters on failure

2014-08-23 Thread Tom Arnfeld
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/#review51342 --- Ship it! Ship It! - Tom Arnfeld On Aug. 21, 2014, 6:22 p.m., Nik

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/#review51238 --- Bad patch! Reviews applied: [24939] Failed command: git apply --in

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
> On Aug. 21, 2014, 5:34 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 1633 > > > > > > Remove the space after inet_ntoa. > > > > inet_ntoa(addr.sin_addr) > > Vinod Kone wrote: > grea

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/ --- (Updated Aug. 21, 2014, 6:22 p.m.) Review request for mesos. Bugs: MESOS-1728

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Vinod Kone
> On Aug. 21, 2014, 5:34 p.m., Jie Yu wrote: > > 3rdparty/libprocess/src/process.cpp, line 1633 > > > > > > Remove the space after inet_ntoa. > > > > inet_ntoa(addr.sin_addr) great. mind also adding this to

Re: Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/#review51190 --- Ship it! Thanks! 3rdparty/libprocess/src/process.cpp

Review Request 24939: Report bind parameters on failure

2014-08-21 Thread Nikita Vetoshkin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24939/ --- Review request for mesos. Bugs: MESOS-1728 https://issues.apache.org/jira/b