---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 16, 2014, 9:05 nachm.)
Review request for mesos and Vinod Kone.
On Sept. 15, 2014, 9:02 nachm., Vinod Kone wrote:
CHANGELOG, lines 1-9
https://reviews.apache.org/r/25035/diff/7/?file=688718#file688718line1
Thinking a bit more about this and talking to others. Adding
deprecations in a bug fix release is bit weird.
2 options.
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote:
src/master/hierarchical_allocator_process.hpp, line 837
https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837
What happens in the case where all CPUs are taken but memory is
available? It looks like it
On Sept. 15, 2014, 3:23 nachm., Timothy St. Clair wrote:
src/master/hierarchical_allocator_process.hpp, line 837
https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837
What happens in the case where all CPUs are taken but memory is
available? It looks like it
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote:
src/master/hierarchical_allocator_process.hpp, line 837
https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837
What happens in the case where all CPUs are taken but memory is
available? It looks like it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53621
---
Patch looks great!
Reviews applied: [25035]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53343
---
src/master/hierarchical_allocator_process.hpp
On Sept. 15, 2014, 3:23 p.m., Timothy St. Clair wrote:
src/master/hierarchical_allocator_process.hpp, line 837
https://reviews.apache.org/r/25035/diff/7/?file=688721#file688721line837
What happens in the case where all CPUs are taken but memory is
available? It looks like it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53362
---
Minor nits and we will get this committed. Thanks for your patience
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53280
---
Patch looks great!
Reviews applied: [25035]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 13, 2014, 6:56 nachm.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 13, 2014, 7:10 nachm.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53027
---
Patch looks great!
Reviews applied: [25035]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 10, 2014, 10 nachm.)
Review request for mesos and Vinod Kone.
On Sept. 9, 2014, 7:10 nachm., Vinod Kone wrote:
src/master/master.cpp, line 1901
https://reviews.apache.org/r/25035/diff/4/?file=682182#file682182line1901
I like these warnings.
Are you planning to get this in to 0.20.1 or 0.21.0 ? If the former,
can you add this to
On Sept. 9, 2014, 7:10 p.m., Vinod Kone wrote:
src/master/master.cpp, line 1901
https://reviews.apache.org/r/25035/diff/4/?file=682182#file682182line1901
I like these warnings.
Are you planning to get this in to 0.20.1 or 0.21.0 ? If the former,
can you add this to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review53002
---
src/common/resources.cpp
On Sept. 11, 2014, 5:35 a.m., Vinod Kone wrote:
Can you also update the summary of the review to something more meaningful? We
typically use the summary to generate the commit message.
- Vinod
---
This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review52763
---
src/master/hierarchical_allocator_process.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 6, 2014, 6:37 nachm.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review52547
---
Bad patch!
Reviews applied: [25035]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review52550
---
Patch looks great!
Reviews applied: [25035]
All tests passed.
-
On Sept. 2, 2014, 5:53 p.m., Vinod Kone wrote:
src/master/hierarchical_allocator_process.hpp, lines 825-840
https://reviews.apache.org/r/25035/diff/2/?file=672690#file672690line825
I suggest to delete this comment altogether because frameworks can
utilize offers with either no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Sept. 2, 2014, 5:52 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review52048
---
Mind writing a test for this in allocator_tests.cpp?
On Sept. 2, 2014, 5:53 nachm., Vinod Kone wrote:
src/master/hierarchical_allocator_process.hpp, lines 825-840
https://reviews.apache.org/r/25035/diff/2/?file=672690#file672690line825
I suggest to delete this comment altogether because frameworks can
utilize offers with either no
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/#review52003
---
Patch looks great!
Reviews applied: [25035]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Aug. 30, 2014, 6:34 nachm.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
(Updated Aug. 26, 2014, 7:53 vorm.)
Review request for mesos.
Changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25035/
---
Review request for mesos.
Bugs: MESOS-1688
30 matches
Mail list logo
