Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/#review51945 --- Patch looks great! Reviews applied: [25084] All tests passed. - M

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-29 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 29, 2014, 7:07 p.m.) Review request for mesos, Adam B and Benjami

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/#review51868 --- Patch looks great! Reviews applied: [25084] All tests passed. - M

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/#review51743 --- Looks pretty good. Just a couple questions about #if logic, testing

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-27 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 28, 2014, 12:51 a.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 27, 2014, 12:39 a.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 27, 2014, 12:38 a.m.) Review request for mesos, Adam B and Benjam

Re: Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- (Updated Aug. 26, 2014, 11:56 p.m.) Review request for mesos, Adam B and Benjam

Review Request 25084: Switched to single variadic 'join' function

2014-08-26 Thread Patrick Reilly
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25084/ --- Review request for mesos, Adam B and Benjamin Hindman. Bugs: MESOS-1733 htt