Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2015-01-17 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/#review68555 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-15 Thread Kamil Domanski
> On Sept. 15, 2014, 7:15 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 111 > > > > > > what happens if i pass in (by accident) a NULL FILE pointer? it might > > end up

Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-15 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/#review53356 --- 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp

Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/#review53300 --- Patch looks great! Reviews applied: [25623] All tests passed. - M

Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-14 Thread Kamil Domanski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/ --- (Updated Sept. 14, 2014, 8:25 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/#review53291 --- Bad patch! Reviews applied: [25623] Failed command: ./support/meso

Review Request 25623: MESOS-1794: allow CURL download into any FD

2014-09-14 Thread Kamil Domanski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25623/ --- Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Vinod Ko