Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/ --- Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and Vinod K

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54070 --- Patch looks great! Reviews applied: [25858] All tests passed. - M

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54125 --- Thanks Jie! 1st pass testing worked, but I need to beat on it some m

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Jie Yu
> On Sept. 22, 2014, 4:31 p.m., Timothy St. Clair wrote: > > src/linux/cgroups.cpp, line 1795 > > > > > > I think I've missed something subtle, how did you bypass the cleanup > > semantics? The isolators won't try t

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Jie Yu
> On Sept. 22, 2014, 4:31 p.m., Timothy St. Clair wrote: > > Thanks Jie! 1st pass testing worked, but I need to beat on it some more. > > > > Normally I would say we should probably separate out the cleanup work from > > the feature mod, but it's not that important to me. Sorry about that. I

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54141 --- Ship it! src/linux/cgroups.cpp

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Jie Yu
> On Sept. 22, 2014, 5:33 p.m., Ian Downes wrote: > > src/linux/cgroups.cpp, line 517 > > > > > > Not your code, but it's a little silly to do this every time... Added a TODO. - Jie ---

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Timothy St. Clair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54165 --- Ship it! Ship It! - Timothy St. Clair On Sept. 20, 2014, 12:21 a

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54164 --- src/linux/cgroups.cpp

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/ --- (Updated Sept. 22, 2014, 8:35 p.m.) Review request for mesos, Ben Mahler, Ian D

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

2014-09-22 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54187 --- Ship it! Ship It! - Timothy Chen On Sept. 22, 2014, 8:35 p.m., J