---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Nov. 4, 2014, 8:58 a.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59716
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Nov. 4, 2014, 10:41 a.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59799
---
src/slave/slave.cpp
On Nov. 4, 2014, 11:24 a.m., Vinod Kone wrote:
src/slave/slave.cpp, line 2959
https://reviews.apache.org/r/26382/diff/13-14/?file=748368#file748368line2959
hmm. sendExecutorTerminatedUpdate sounds like we are sending an
update about executor terminated (e.g.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Nov. 4, 2014, 12:15 p.m.)
Review request for mesos, Vinod Kone and
On Nov. 4, 2014, 9:46 a.m., Vinod Kone wrote:
include/mesos/mesos.proto, line 640
https://reviews.apache.org/r/26382/diff/11-12/?file=746438#file746438line640
just looked at the code for command executor, and the only way the
command executor exits with a pending task is if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59841
---
Ship it!
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Nov. 4, 2014, 2:19 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59607
---
Ship it!
Ship It!
- Vinod Kone
On Oct. 31, 2014, 10:09 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59654
---
src/slave/slave.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59656
---
Couple more things that I wanted to add before I forget.
-- Can
On Nov. 3, 2014, 2:13 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 2952
https://reviews.apache.org/r/26382/diff/11/?file=746449#file746449line2952
So, after thinking a bit more and looking at MESOS-343, what we really
want here is to set the reason for failed as oom or
On Nov. 3, 2014, 2:18 p.m., Vinod Kone wrote:
Couple more things that I wanted to add before I forget.
-- Can you update the change log with these changes? You can add it under
API changes subsection.
-- Email the dev list about the changes coming in 0.21.0.
-- FWICT, we
On Nov. 3, 2014, 10:13 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 2952
https://reviews.apache.org/r/26382/diff/11/?file=746449#file746449line2952
So, after thinking a bit more and looking at MESOS-343, what we really
want here is to set the reason for failed as oom or
On Nov. 3, 2014, 2:13 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 2952
https://reviews.apache.org/r/26382/diff/11/?file=746449#file746449line2952
So, after thinking a bit more and looking at MESOS-343, what we really
want here is to set the reason for failed as oom or
On Nov. 3, 2014, 10:13 p.m., Vinod Kone wrote:
src/slave/slave.cpp, line 2952
https://reviews.apache.org/r/26382/diff/11/?file=746449#file746449line2952
So, after thinking a bit more and looking at MESOS-343, what we really
want here is to set the reason for failed as oom or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Nov. 3, 2014, 4:38 p.m.)
Review request for mesos, Vinod Kone and
On Oct. 30, 2014, 12:09 a.m., Vinod Kone wrote:
looking good. some minor comments.
are you going to follow up with a review for metrics based on source and
reason? that would make this effort super useful.
Dominic Hamon wrote:
yes!
i started to fold it into this one
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59398
---
Ship it!
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 31, 2014, 3:09 p.m.)
Review request for mesos, Vinod Kone and
On Oct. 31, 2014, 1:53 p.m., Vinod Kone wrote:
include/mesos/mesos.proto, line 641
https://reviews.apache.org/r/26382/diff/9-10/?file=741848#file741848line641
forgot to kill this?
still used in master when checking offer validity.
- Dominic
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59433
---
Patch looks great!
Reviews applied: [26817, 26382]
All tests
On Oct. 24, 2014, 11:08 a.m., Vinod Kone wrote:
include/mesos/mesos.proto, line 636
https://reviews.apache.org/r/26382/diff/7/?file=727940#file727940line636
I think this will become a crutch. We should know the reasons for why a
task is lost. i.e., kill this.
Dominic Hamon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 29, 2014, 1:45 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59045
---
Patch looks great!
Reviews applied: [26817, 26382]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review59136
---
Patch looks great!
Reviews applied: [26817, 26382]
All tests
On Oct. 24, 2014, 6:08 p.m., Vinod Kone wrote:
src/master/master.cpp, line 2301
https://reviews.apache.org/r/26382/diff/7/?file=727958#file727958line2301
why is this TASK_ERROR instead of TASK_LOST? A relaunch would likely
succeed here right?
Dominic Hamon wrote:
I
On Oct. 24, 2014, 11:08 a.m., Vinod Kone wrote:
include/mesos/mesos.proto, lines 624-629
https://reviews.apache.org/r/26382/diff/7/?file=727940#file727940line624
Pull this one and Reason inside TaskStatus.
Also kill the SOURCE_ and REASON_ prefixes.
and not enum
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 27, 2014, 10:18 a.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 21, 2014, 1:29 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review57665
---
Patch looks great!
Reviews applied: [26817, 26382]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 20, 2014, 10:25 a.m.)
Review request for mesos, Vinod Kone and
On Oct. 16, 2014, 1:44 p.m., Alexander Rukletsov wrote:
src/examples/balloon_framework.cpp, line 134
https://reviews.apache.org/r/26382/diff/2/?file=723169#file723169line134
You say it's reason, but output message. Is it on purpose?
I changed the output from 'Reason' to 'Message'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 17, 2014, 10:07 a.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review57176
---
Patch looks great!
Reviews applied: [26817, 26382]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 17, 2014, 1:55 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review57226
---
Bad patch!
Reviews applied: [26817, 26382]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:26 p.m.)
Review request for mesos and Vinod Kone.
On Oct. 7, 2014, 11:50 a.m., Vinod Kone wrote:
src/master/master.cpp, line 2264
https://reviews.apache.org/r/26382/diff/1/?file=714252#file714252line2264
invalid offers is a bit tricky. because there are several subcases here.
1) framework used the offer after the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 12:28 p.m.)
Review request for mesos, Vinod Kone and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review56979
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/
---
(Updated Oct. 16, 2014, 1:20 p.m.)
Review request for mesos, Vinod Kone and
On Oct. 16, 2014, 12:43 p.m., Bill Farner wrote:
include/mesos/mesos.proto, line 664
https://reviews.apache.org/r/26382/diff/2/?file=723164#file723164line664
`required` unsafe to introduce without a default, right? IIUC it means
you can't read a message that doesn't have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review56987
---
include/mesos/mesos.proto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26382/#review57023
---
Bad patch!
Reviews applied: [26817, 26382]
Failed command: git
48 matches
Mail list logo
