Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review56498 --- Ship it! Minor consistency nit, but otherwise quite shippable. 3r

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/ --- (Updated Oct. 10, 2014, 12:46 a.m.) Review request for mesos, Adam B and Domini

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/ --- (Updated Oct. 10, 2014, 12:44 a.m.) Review request for mesos, Adam B and Domini

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
> On Oct. 9, 2014, 9:59 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, lines 442-443 > > > > > > Hm.. could we avoid the assumption that stringify() keeps errno intact? > > >

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review56060 --- Looks good, just two minor issues below. Deferring to adam and domi

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review56007 --- Ship it! Ship It! - Dominic Hamon On Oct. 9, 2014, 9:35 a.m., Co

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
> On Oct. 9, 2014, 3:49 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Dominic Hamon
> On Oct. 8, 2014, 8:49 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
> On Oct. 9, 2014, 3:49 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Dominic Hamon
> On Oct. 8, 2014, 8:49 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/ --- (Updated Oct. 9, 2014, 4:35 p.m.) Review request for mesos, Adam B and Dominic

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Cody Maloney
> On Oct. 9, 2014, 3:49 a.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review55961 --- Ship it! Please fix the shadowed variable and maybe the minor align

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-09 Thread Adam B
> On Oct. 8, 2014, 8:49 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp, line 36 > > > > > > it might be worth considering using stringstream here to build the same > > err

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-08 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review55946 --- Ship it! Ship It! 3rdparty/libprocess/3rdparty/stout/include/stou

Re: Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/#review55930 --- 3rdparty/libprocess/3rdparty/stout/include/stout/stringify.hpp

Review Request 26472: stout: Always use stout ABORT() rather than system abort()

2014-10-08 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26472/ --- Review request for mesos, Adam B and Dominic Hamon. Bugs: MESOS-1870 https: