Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-11 Thread Timothy Chen
> On Oct. 11, 2014, 5:37 p.m., Benjamin Hindman wrote: > > src/docker/docker.cpp, line 695 > > > > > > Can you not make this const? I can't since discard() is not a const operation - Timothy --

Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/#review56292 --- Ship it! src/docker/docker.cpp

Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-09 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/ --- (Updated Oct. 9, 2014, 9:38 p.m.) Review request for mesos and Benjamin Hindman

Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/#review56057 --- Ah, I suspected this would happen.. =/ https://issues.apache.org/jir

Re: Review Request 26487: Perform read right after subprocess for docker ps

2014-10-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/#review55960 --- Patch looks great! Reviews applied: [26487] All tests passed. - M

Review Request 26487: Perform read right after subprocess for docker ps

2014-10-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26487/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript