Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 21, 2014, 10:22 p.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review57631 --- Ship it! src/slave/slave.cpp

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 20, 2014, 11:52 p.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 17, 2014, 6:58 p.m., Ben Mahler wrote: > > src/messages/messages.proto, line 55 > > > > > > Wonder if it's time for a UUID wrapper message type akin to what we did > > with all of our _ID types.. > > > >

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review57185 --- Looks good, mainly just comments about adding more comments for myse

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 17, 2014, 12:26 a.m.) Review request for mesos, Adam B, Ben Mahle

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 14, 2014, 9:03 p.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- (Updated Oct. 15, 2014, 9:29 p.m.) Review request for mesos, Adam B, Ben Mahler

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 6:26 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 1014 > > > > > > What are your guarantees that task_id() is in the states map? Maybe > > guard it? it is inside a "if states contain

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

> On Oct. 15, 2014, 4:03 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 938-948 > > > > > > Couldn't the Slave and the SUM get out of sync here? Right now, the SUM > > will flush its pending status updates as soon

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review56758 --- src/slave/slave.cpp

Re: Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/#review56604 --- Looking good. I'm glad to see some attention paid to the status upda

Review Request 26699: Updated slave re-registration to send unacknowledged task states.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26699/ --- Review request for mesos, Adam B, Ben Mahler, and Niklas Nielsen. Bugs: MESOS-1