Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 16, 2014, 4:15 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56988 --- Ship it! I'll fix the last nits. src/module/manager.hpp

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 16, 2014, 2:43 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Kapil Arya
> On Oct. 16, 2014, 12:59 p.m., Till Toenshoff wrote: > > src/module/manager.cpp, lines 195-197 > > > > > > This sounds very temporarily almost like a TODO. Fixed the explanation. - Kapil -

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56934 --- Patch looks great! Reviews applied: [26674, 26789] All tests passe

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56928 --- Ship it! Not sure what you mean by side-effects of dlclose on OSX.

Re: Review Request 26789: Allow unloading a single module.

2014-10-16 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 16, 2014, 11:12 a.m.) Review request for mesos, Niklas Nielsen an

Re: Review Request 26789: Allow unloading a single module.

2014-10-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56893 --- Bad patch! Reviews applied: [26789] Failed command: git apply --in

Re: Review Request 26789: Allow unloading a single module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 15, 2014, 9:19 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 26789: Allow unloading a single module.

2014-10-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/#review56850 --- LGTM module my comments src/module/manager.cpp

Re: Review Request 26789: Allow unloading a single module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- (Updated Oct. 15, 2014, 8:18 p.m.) Review request for mesos, Niklas Nielsen and

Review Request 26789: Allow unloading a single module.

2014-10-15 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26789/ --- Review request for mesos, Niklas Nielsen and Till Toenshoff. Repository: mesos-