Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/#review56909 --- Patch looks great! Reviews applied: [26798] All tests passed. -

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/ --- (Updated Oct. 16, 2014, 5:17 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote: support/apply-review.sh, line 20 https://reviews.apache.org/r/26798/diff/1/?file=722887#file722887line20 Update usage? Cody Maloney wrote: I was explicitly leaving it out because process wise committers should look at the diff

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/#review56980 --- Patch looks great! Reviews applied: [26798] All tests passed. -

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/ --- (Updated Oct. 16, 2014, 5:36 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26798/#review56894 --- Ship it! support/apply-review.sh

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote: support/apply-review.sh, line 20 https://reviews.apache.org/r/26798/diff/1/?file=722887#file722887line20 Update usage? I was explicitly leaving it out because process wise committers should look at the diff before they commit it. Not

Re: Review Request 26798: Create a full commit for every review being tested, checking them with the pre-commit hook

On Oct. 16, 2014, 5:36 a.m., Vinod Kone wrote: support/apply-review.sh, line 20 https://reviews.apache.org/r/26798/diff/1/?file=722887#file722887line20 Update usage? Cody Maloney wrote: I was explicitly leaving it out because process wise committers should look at the diff