Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-11-11 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/#review60868 --- 3rdparty/libprocess/include/process/reap.hpp~

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-11-04 Thread Alexander Rukletsov
> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote: > > There is already a constant, MESOS-1935 is to ensure that code that > > previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp. > > Aditi Bhatnagar wrote: > Sorry, but I didn't find the constants in > https://github.com

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-11-03 Thread Aditi Bhatnagar
> On Oct. 22, 2014, 5:26 p.m., Ben Mahler wrote: > > There is already a constant, MESOS-1935 is to ensure that code that > > previously hardcoded Seconds(1) now uses MAX_REAP_INTERVAL from reap.hpp. Sorry, but I didn't find the constants in https://github.com/apache/mesos/blob/4693728e4f604a1c

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-10-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/#review57826 --- There is already a constant, MESOS-1935 is to ensure that code that

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-10-22 Thread Dominic Hamon
> On Oct. 22, 2014, 8:12 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [27040] > > > > Failed command: ./support/apply-review.sh -n -r 27040 > > > > Error: > > --2014-10-22 15:12:21-- https://reviews.apache.org/r/27040/diff/raw/ > > Resolving reviews.apache.org (review

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/#review57798 --- Bad patch! Reviews applied: [27040] Failed command: ./support/appl

Re: Review Request 27040: Replace hard-coded reap interval with a constant

2014-10-22 Thread Aditi Bhatnagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/ --- (Updated Oct. 22, 2014, 2:45 p.m.) Review request for mesos and Dominic Hamon.

Review Request 27040: Replace hard-coded reap interval with a constant

2014-10-22 Thread Aditi Bhatnagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27040/ --- Review request for mesos and Dominic Hamon. Bugs: MESOS-1935 https://issues