Review Request 27091: Move Linux namespace functions into linux/.

2014-10-23 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos-git Descri

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-23 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/ --- (Updated Oct. 23, 2014, 6:20 p.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58201 --- Looks like this isn't a pure code movement from a few leftover inclu

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-24 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/ --- (Updated Oct. 24, 2014, 2:53 p.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27091/#review58419 --- Ship it! src/tests/ns_tests.cpp

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-27 Thread Ian Downes
> On Oct. 24, 2014, 4:04 p.m., Ben Mahler wrote: > > src/tests/setns_test_helper.hpp, line 25 > > > > > > I guess you're using subcommand because you're anticipating commands > > here other than "test"? > > > >

Re: Review Request 27091: Move Linux namespace functions into linux/.

2014-10-29 Thread Ian Downes
> On Oct. 23, 2014, 6:58 p.m., Ben Mahler wrote: > > src/linux/ns.hpp, line 65 > > > > > > s/ns/namespace/ for the argument I'd like to avoid using the reserved word 'namespace' in code, event for argument names. >