Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 12, 2014, 12:28 a.m.) Review request for mesos, Dominic Hamon, Jo

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60827 --- 3rdparty/libprocess/include/process/node.hpp

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 11, 2014, 12:54 p.m.) Review request for mesos, Dominic Hamon, Jo

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 42 > > > > > > Does this compile...? It should be `!(this->operator == (that));` for > > it to be valid. Prefera

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote: > > > > Michael Park wrote: > Looks good, fairly straigth forward transformation :) s/straigth/straight/ - Michael --- This is an automatically generated e-mail. To reply, visit: h

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

> On Nov. 11, 2014, 1:59 a.m., Michael Park wrote: > > Looks good, fairly straigth forward transformation :) - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60720 -

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60720 --- 3rdparty/libprocess/include/process/node.hpp

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

> On Nov. 7, 2014, 5:12 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 51 > > > > > > this should be on the previous line and spaced differently - did you > > run the check style scri

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 5:34 p.m.) Review request for mesos, Dominic Hamon, Jori

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60341 --- Ship it! so much cleaner! fix up the style nits below and i'll wai

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 3:49 p.m.) Review request for mesos, Dominic Hamon, Jori

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 7, 2014, 3:23 a.m.) Review request for mesos, Dominic Hamon, Jori

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class

> On Nov. 6, 2014, 5:44 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/pid.hpp, line 59 > > > > > > this can be simplified by adding an operator < to Node. I didn't noticed that. Actually there is a

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class

> On Nov. 6, 2014, 5:44 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/src/http.cpp, line 90 > > > > > > actually, a utility method on Node to return the string host might be > > useful. Or a Try host, actually. I

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/#review60189 --- 3rdparty/libprocess/include/process/node.hpp

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 6, 2014, 3:07 a.m.) Review request for mesos, Dominic Hamon, Jori

Re: Review Request 27446: libprocess: Replaced the ip and port pairs from UPID class and process namespace with Node class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27446/ --- (Updated Nov. 6, 2014, 2:51 a.m.) Review request for mesos, Dominic Hamon, Jori