Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/ --- (Updated Nov. 11, 2014, 4:52 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/#review60832 --- LGTM - see comment below 3rdparty/libprocess/include/process/timer

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

> On Nov. 11, 2014, 11:39 a.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/timer.hpp, line 14 > > > > > > I would really love more documentation on these concepts. I see that > > the timer class had

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/#review60911 --- Hey Ben, would love to help review these. Any chance you could link

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

> On Nov. 11, 2014, 5:04 p.m., Ben Mahler wrote: > > Hey Ben, would love to help review these. Any chance you could link a > > ticket in here with the context? And/or update the description on these > > changes to say a bit more than "See summary"? > > > > It's a bit tough to navigate this cha

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

> On Nov. 12, 2014, 1:04 a.m., Ben Mahler wrote: > > Hey Ben, would love to help review these. Any chance you could link a > > ticket in here with the context? And/or update the description on these > > changes to say a bit more than "See summary"? > > > > It's a bit tough to navigate this cha

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

> On Nov. 12, 2014, 1:04 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/timer.hpp, line 53 > > > > > > Looks like you need an include for clock.hpp..? Does this compile if > > Clock is not transitively

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/ --- (Updated Nov. 14, 2014, 9:40 p.m.) Review request for mesos, Ben Mahler, Jie Yu

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/ --- (Updated Nov. 14, 2014, 11:15 p.m.) Review request for mesos, Ben Mahler, Jie Y

Re: Review Request 27496: Replaced Timer::create/cancel with Clock::timer/cancel.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27496/#review61550 --- Ship it! Ship It! - Niklas Nielsen On Nov. 14, 2014, 3:15 p.m.,