Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-12 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 12, 2014, 10:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review61011 --- Ship it! Ship It! - Vinod Kone On Nov. 12, 2014, 6:06 p.m.,

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60358 --- src/master/master.cpp

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-07 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/#review60360 --- NM. Looks like review bot caught this. Did you forget to run 'make

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-07 Thread Dominic Hamon
On Nov. 7, 2014, 11:25 a.m., Vinod Kone wrote: NM. Looks like review bot caught this. Did you forget to run 'make check' ? Also, before this lands you should send an email to dev list to solicit feedback. This is a big change. i ran make check, i had GTEST_FILTER set. sorry. -

Re: Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-07 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- (Updated Nov. 7, 2014, 2:04 p.m.) Review request for mesos and Vinod Kone.

Review Request 27685: Introduced TASK_ERROR for unrecoverable errors

2014-11-06 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27685/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1143