Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/#review60929 --- Ship it! Ship It! - Vinod Kone On Nov. 11, 2014, 7:59 p.m., Jie

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/#review60845 --- Patch looks great! Reviews applied: [27769, 27843] All tests passe

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/ --- (Updated Nov. 11, 2014, 7:59 p.m.) Review request for mesos, Ben Mahler and Vin

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

> On Nov. 11, 2014, 7:25 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1998 > > > > > > why pull this down? Oh, that's because the following changes. I need to validate all task.executor().resources() firs

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

> On Nov. 11, 2014, 7:25 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 1889 > > > > > > Hmm. Not sure why ended up using Error() instead of string? The string > > version was concise and readable. AFAICT, t

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/#review60816 --- src/master/master.cpp

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/#review60721 --- Patch looks great! Reviews applied: [27769, 27843] All tests passe

Re: Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/ --- (Updated Nov. 10, 2014, 11:41 p.m.) Review request for mesos, Ben Mahler and Vi

Review Request 27843: Moved all resources validation logic to ResourceUsageChecker.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27843/ --- Review request for mesos, Ben Mahler and Vinod Kone. Summary (updated)