Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Jan. 8, 2015, 9:55 a.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 24, 2014, 9:20 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 2669-2676 > > > > > > There should only be one CommandInfo to modify, so you can use a CHECK > > or make this an if/else > > Alexander Rukl

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 28, 2014, 8:32 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 2666-2667 > > > > > > Do you plan to fix this before committing? > > Niklas Nielsen wrote: > Requires ACL support, so we chose that as a

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 24, 2014, 1:20 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 2661-2664 > > > > > > Why not take `flags` as a parameter too? Then setGracePeriod(task, > > flags) or setGracePeriod(task, grace_period) co

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 28, 2014, 12:32 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 2666-2667 > > > > > > Do you plan to fix this before committing? Requires ACL support, so we chose that as a non-target for this patch. -

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 24, 2014, 1:20 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 2669-2676 > > > > > > There should only be one CommandInfo to modify, so you can use a CHECK > > or make this an if/else > > Alexander Rukl

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review66208 --- src/slave/slave.cpp

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 24, 2014, 9:20 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 257 > > > > > > grace_period_seconds? To make the unit explicit > > Is there a default, or does it default to None? There is a defau

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review66019 --- include/mesos/mesos.proto

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Dec. 23, 2014, 3:25 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 3, 2014, 1:20 p.m., Niklas Nielsen wrote: > > src/slave/slave.hpp, line 275 > > > > > > /es/e/ > > Alexander Rukletsov wrote: > Current implementation updates all present CommandInfo fields in a > TaskI

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 3, 2014, 9:20 p.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 2675 > > > > > > else if? If the task has a command, it cannot have an executor > > Alexander Rukletsov wrote: > There is only one

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Dec. 17, 2014, 11:25 p.m.) Review request for mesos, Ben Mahler, Nikla

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Dec. 3, 2014, 9:20 p.m., Niklas Nielsen wrote: > > src/slave/slave.hpp, line 275 > > > > > > /es/e/ Current implementation updates all present CommandInfo fields in a TaskInfo. > On Dec. 3, 2014, 9:20 p.m., Nik

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review63475 --- src/slave/slave.hpp

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Nov. 24, 2014, 5:07 p.m.) Review request for mesos, Ben Mahler, Niklas

Re: Review Request 28063: Introduced grace period in CommandInfo.

> On Nov. 19, 2014, 11:38 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, lines 255-256 > > > > > > Explain the effect of setting it - not how it is implemented :-) > > In other words, the current commen

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/#review62276 --- include/mesos/mesos.proto

Re: Review Request 28063: Introduced grace period in CommandInfo.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28063/ --- (Updated Nov. 17, 2014, 12:09 p.m.) Review request for mesos, Ben Mahler, Nikla