Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62158 --- support/post-reviews.py

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/ --- (Updated Nov. 19, 2014, 5:22 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62170 --- Ship it! Ship It! - Niklas Nielsen On Nov. 19, 2014, 9:22 a.m.,

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Joris Van Remoortere
On Nov. 19, 2014, 4:42 p.m., Niklas Nielsen wrote: support/post-reviews.py, line 220 https://reviews.apache.org/r/28205/diff/1/?file=768403#file768403line220 Won't this be a problem for folks where 'diff' isn't added to the url i.e. the trailing slash will be left in, in that

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62173 --- I've never had the issue of a trailing diff.. I wonder what's

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Joris Van Remoortere
On Nov. 19, 2014, 5:31 p.m., Dominic Hamon wrote: I've never had the issue of a trailing diff.. I wonder what's different about your setup. At least for BenH and myself when you try and update a review the url with diff/ at the end doesn't seem to allow post-reviews to match up the

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62184 --- Patch looks great! Reviews applied: [28205] All tests passed. -

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62194 --- support/post-reviews.py

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/ --- (Updated Nov. 19, 2014, 10:29 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-19 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/ --- (Updated Nov. 19, 2014, 10:44 p.m.) Review request for mesos, Benjamin Hindman

Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-18 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/ --- Review request for mesos, Benjamin Hindman and Niklas Nielsen. Repository:

Re: Review Request 28205: Removing trailing diff/ from Review line in commit message.

2014-11-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28205/#review62124 --- Patch looks great! Reviews applied: [28205] All tests passed. -