Re: Review Request 28618: Splitted resource and resource usage checkers.

2014-12-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28618/#review63724 --- Ship it! src/master/master.cpp

Re: Review Request 28618: Splitted resource and resource usage checkers.

2014-12-04 Thread Jie Yu
> On Dec. 3, 2014, 8:20 p.m., Ben Mahler wrote: > > src/master/master.cpp, lines 1946-1948 > > > > > > This check misses the case where a task explicitly uses no resources: > > cpus=0, for example. > > > > H

Re: Review Request 28618: Splitted resource and resource usage checkers.

2014-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28618/#review63636 --- Patch looks great! Reviews applied: [28616, 28618] All tests passe

Review Request 28618: Splitted resource and resource usage checkers.

2014-12-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28618/ --- Review request for mesos and Ben Mahler. Bugs: mesos-2031 https://issues.ap