Re: Review Request 30962: Enabled environment decorator to override.

2015-04-20 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated April 20, 2015, 1:16 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review79802 --- Ship it! Ship It! - Adam B On April 7, 2015, 5:57 p.m., Niklas

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-07 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated April 7, 2015, 5:57 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30962: Enabled environment decorator to override.

2015-04-03 Thread Niklas Nielsen
On March 30, 2015, 3:28 a.m., Adam B wrote: src/hook/manager.cpp, line 130 https://reviews.apache.org/r/30962/diff/5/?file=894741#file894741line130 And if (result.isNone()), is that really supposed to mean that this hook didn't want to modify the env, so the HookManager can leave

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review78191 --- src/hook/manager.cpp

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-17 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review76819 --- Ship it! src/examples/test_hook_module.cpp

Re: Review Request 30962: Enabled environment decorator to override.

2015-03-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated March 13, 2015, 4:04 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated Feb. 26, 2015, 5:55 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review73455 --- Ship it! src/hook/manager.cpp

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-19 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review73180 --- src/hook/manager.cpp

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-13 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- (Updated Feb. 13, 2015, 3:28 p.m.) Review request for mesos, Ben Mahler and

Review Request 30962: Enabled environment decorator to override.

2015-02-12 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/ --- Review request for mesos, Ben Mahler and Kapil Arya. Bugs: MESOS-2351

Re: Review Request 30962: Enabled environment decorator to override.

2015-02-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review72302 --- src/hook/manager.cpp